Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg sciml simulate #2932

Merged
merged 7 commits into from
Mar 6, 2024
Merged

reorg sciml simulate #2932

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
39fb1f4
reorg sciml simulate
mwdchang Mar 5, 2024
c9550a1
Merge branch 'main' into reorg-simulate-operators
YohannParis Mar 6, 2024
911be20
reorg
mwdchang Mar 6, 2024
ab45cab
fix, clean up
mwdchang Mar 6, 2024
39eb5a7
Merge remote-tracking branch 'origin/main' into reorg-simulate-operators
mwdchang Mar 6, 2024
f672265
clean up
mwdchang Mar 6, 2024
86ccbde
clean up
mwdchang Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 32 additions & 37 deletions packages/client/hmi-client/src/workflow/ops/simulate-julia/tera-simulate-julia.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
:style="{ marginRight: 'auto' }"
label="Run"
icon="pi pi-play"
@click="runSimulate"
@click="run"
:disabled="showSpinner"
/>
<Button
Expand Down Expand Up @@ -128,7 +128,6 @@ import { Poller, PollerState } from '@/api/api';

import {
getRunResult,
getSimulation,
makeForecastJob,
querySimulationInProgress,
pollAction
Expand Down Expand Up @@ -203,15 +202,21 @@ const updateState = () => {
emit('update-state', state);
};

const runSimulate = async () => {
const modelConfigurationList = props.node.inputs[0].value;
if (!modelConfigurationList?.length) return;
// Main entry point
const run = async () => {
showSpinner.value = true;
const simulationId = await makeForecastRequest();
await pollResult(simulationId);
await processResult(simulationId);
await lazyLoadSimulationData(simulationId);
YohannParis marked this conversation as resolved.
Show resolved Hide resolved
showSpinner.value = false;
};

// Since we've disabled multiple configs to a simulation node, we can assume only one config
const configId = modelConfigurationList[0];
const makeForecastRequest = async (): Promise<string> => {
const configId = props.node.inputs[0].value?.[0];
if (!configId) throw new Error('No model configuration found for simulate');

const state = props.node.state;

const payload: SimulationRequest = {
projectId: useProjects().activeProject.value?.id as string,
modelConfigId: configId,
Expand All @@ -223,49 +228,45 @@ const runSimulate = async () => {
engine: 'sciml'
};
const response = await makeForecastJob(payload);
getStatus(response.id);
return response.id;
};

const getStatus = async (runId: string) => {
showSpinner.value = true;
const pollResult = async (runId: string) => {
poller
.setInterval(3000)
.setThreshold(300)
.setPollAction(async () => pollAction(runId));
const pollerResults = await poller.start();

if (pollerResults.state === PollerState.Cancelled) {
showSpinner.value = false;
return;
return pollerResults;
}
if (pollerResults.state !== PollerState.Done || !pollerResults.data) {
// throw if there are any failed runs for now
showSpinner.value = false;
logger.error(`Simulate: ${runId} has failed`, {
toastTitle: 'Error - Julia'
});
throw Error('Failed Runs');
}
return pollerResults;
};

const processResult = async (runId: string) => {
const state = _.cloneDeep(props.node.state);
if (state.chartConfigs.length === 0) {
addChart();
}

const sim = await getSimulation(runId);

emit('append-output', {
type: SimulateJuliaOperation.outputs[0].type,
label: `Output - ${props.node.outputs.length + 1}`,
value: runId,
state: {
currentTimespan: sim?.executionPayload.timespan ?? timespan.value,
currentTimespan: state.currentTimespan,
simulationsInProgress: state.simulationsInProgress
},
isSelected: false
});

showSpinner.value = false;
};

const lazyLoadSimulationData = async (runId: string) => {
Expand All @@ -281,12 +282,11 @@ const lazyLoadSimulationData = async (runId: string) => {
if (modelConfiguration) {
const parameters = modelConfiguration.configuration.semantics.ode.parameters;
csvData.forEach((row) =>
parameters.forEach((parameter) => {
parameters.forEach((parameter: any) => {
row[parameter.id] = parameter.value;
})
);
}

runResults.value[runId] = csvData as any;
rawContent.value[runId] = createCsvAssetFromRunResults(runResults.value, runId);
};
Expand Down Expand Up @@ -323,34 +323,29 @@ onMounted(() => {
const runIds = querySimulationInProgress(props.node);
if (runIds.length === 1) {
// there should only be one run happening at a time
getStatus(runIds[0]);
pollResult(runIds[0]);
}
});

onUnmounted(() => {
poller.stop();
});

watch(
() => selectedRunId.value,
() => {
if (selectedRunId.value) {
lazyLoadSimulationData(selectedRunId.value);
}
},
{ immediate: true }
);

watch(
() => props.node.active,
() => {
// Update selected output
if (props.node.active) {
selectedOutputId.value = props.node.active;
}
async () => {
if (!props.node.active) return;
selectedOutputId.value = props.node.active;

// Update Wizard form fields with current selected output state timespan
timespan.value = props.node.state.currentTimespan;

// Resume or fetch result
const simulationId = selectedRunId.value;
const response = await pollResult(simulationId);
if (response?.state !== PollerState.Done) return;
await processResult(simulationId);
await lazyLoadSimulationData(simulationId);
},
{ immediate: true }
);
Expand Down
Loading