Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intervention pdf goto page #5285

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Intervention pdf goto page #5285

merged 5 commits into from
Oct 25, 2024

Conversation

asylves1
Copy link
Contributor

@asylves1 asylves1 commented Oct 24, 2024 •
edited
Loading

Description

Design Change

  • For interventions with page number, clicking on them will jump to the matching the page in the PDF

Testing:

  • connect a document to the intervention's drill down
  • extract from inputs
  • select a policy and click on an intervention

Notes:

  • At the moment the LLM may not be returning the correct page number in some cases

Resolves #(issue)

@asylves1 asylves1 linked an issue Oct 24, 2024 that may be closed by this pull request
intervention extract from inputs - goto matching pdf page #5246
Closed
@asylves1 asylves1 marked this pull request as ready for review October 24, 2024 18:18
@asylves1 asylves1 requested review from Tom-Szendrey and mwdchang and removed request for YohannParis October 24, 2024 19:00
@mwdchang mwdchang merged commit 56517c2 into main Oct 25, 2024
5 checks passed
@mwdchang mwdchang deleted the intervention-pdf-goto-page branch October 25, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@shawnyama shawnyama shawnyama approved these changes

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

Assignees

@mwdchang mwdchang

@Tom-Szendrey Tom-Szendrey

@shawnyama shawnyama

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

intervention extract from inputs - goto matching pdf page
6 participants
@asylves1 @mwdchang @Tom-Szendrey @shawnyama @blanchco @dgauldie