Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intervention pdf goto page #5285

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Intervention pdf goto page #5285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6627954
draft working version
asylves1 Oct 23, 2024
2147f57
Merge remote-tracking branch 'origin/main' into intervention-pdf-goto…
dgauldie Oct 23, 2024
f3de685
fix prompts a bit
dgauldie Oct 23, 2024
7a2ca7f
Merge branch 'main' into intervention-pdf-goto-page
asylves1 Oct 24, 2024
0054061
suggested changes
asylves1 Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/client/hmi-client/src/components/widgets/tera-pdf-panel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<TabView v-if="pdfs?.length" class="container">
<TabPanel :header="pdf.name" v-for="pdf in pdfs" :key="pdf.name">
<tera-pdf-embed v-if="pdf.isPdf" :pdf-link="pdf.data" :title="pdf.name || ''" />
<tera-pdf-embed v-if="pdf.isPdf" ref="pdfRef" :pdf-link="pdf.data" :title="pdf.name || ''" />
<tera-text-editor v-else :initial-text="pdf.data" />
</TabPanel>
</TabView>
Expand Down Expand Up @@ -29,6 +29,9 @@ const props = defineProps<{
}>();

const pdfs = ref<PdfData[]>(props.pdfs);
const pdfRef = ref(null);

defineExpose({ pdfRef });
</script>

<style scoped>
Expand Down
50 changes: 48 additions & 2 deletions ...nt/src/components/workflow/ops/intervention-policy/tera-intervention-policy-drilldown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
>
<template #content>
<tera-drilldown-section :is-loading="isFetchingPDF">
<tera-pdf-panel :pdfs="pdfData" />
<tera-pdf-panel :pdfs="pdfData" ref="pdfPanelRef" />
</tera-drilldown-section>
</template>
</tera-slider-panel>
Expand Down Expand Up @@ -65,8 +65,16 @@
<Button outlined severity="secondary" label="Reset" @click="onResetPolicy" />
</template>
<ul class="flex flex-column gap-2">
<li v-for="(intervention, index) in knobs.transientInterventionPolicy.interventions" :key="index">
<li
v-for="(intervention, index) in knobs.transientInterventionPolicy.interventions"
:key="index"
@click="selectInterventionPolicy(intervention, index)"
>
<tera-intervention-card
class="intervention"
:class="{
selected: selectedIntervention?.name === intervention?.name && selectedIntervention?.index === index
}"
:intervention="intervention"
:parameterOptions="parameterOptions"
:stateOptions="stateOptions"
Expand Down Expand Up @@ -192,6 +200,8 @@ import {
Intervention,
InterventionPolicy,
Model,
DynamicIntervention,
StaticIntervention,
type TaskResponse,
type DocumentAsset
} from '@/types/Types';
Expand Down Expand Up @@ -256,6 +266,19 @@ const newBlankInterventionPolicy = ref({
interventions: [blankIntervention]
});

interface SelectedIntervention {
index: number;
name: string;
extractionDocumentId?: string;
extractionPage?: number;
staticInterventions: StaticIntervention[];
dynamicInterventions: DynamicIntervention[];
}

const pdfPanelRef = ref();
const pdfViewer = computed(() => pdfPanelRef.value?.pdfRef[0]);
const selectedIntervention = ref<SelectedIntervention | null>(null);

const isPdfSidebarOpen = ref(true);
const isFetchingPDF = ref(false);
const pdfData = ref<{ document: DocumentAsset; data: string; isPdf: boolean; name: string }[]>([]);
Expand Down Expand Up @@ -407,6 +430,15 @@ const fetchInterventionPolicies = async (modelId: string) => {
isFetchingPolicies.value = false;
};

const selectInterventionPolicy = (intervention: Intervention, index: number) => {
selectedIntervention.value = { ...intervention, index };
if (!intervention?.extractionPage) return;

if (pdfViewer.value) {
pdfViewer.value.goToPage(selectedIntervention.value.extractionPage);
}
};

const onUpdateInterventionCard = (intervention: Intervention, index: number) => {
// Clone the entire interventions array
const updatedInterventions = [...knobs.value.transientInterventionPolicy.interventions];
Expand Down Expand Up @@ -670,6 +702,20 @@ button.start-edit {
}
}

.intervention {
background-color: var(--gray-0);
border-left: 4px solid var(--surface-300);

&.selected {
border-left-color: var(--primary-color);
}

&,
&.selected {
transition: border-left-color 250ms;
}
}

.confirm-cancel {
display: flex;
align-items: center;
Expand Down
2 changes: 1 addition & 1 deletion packages/gollm/gollm_openai/prompts/config_from_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
5. For each parameter specified in the AMR model, extract information from the text and create a parameter semantic object. Do not create new parameter semantic objects for parameters that are not included in the original AMR model. If you cannot find a constant value or distribution for the parameter, do not create a parameter semantic object.
6. `observableSemanticList` should be an empty list.
7. `inferredParameterList` should be an empty list.
8. Determine what page that the majority of information was extracted from and set the `extractionPage` value to that page number. If the page number cannot be determined, set it to 0.
8. Determine what page the information was extracted from and set the `extractionPage` value to that page number. If the page number cannot be determined, set it to 0. Only pick one page number. Do not provide a range.

Do not respond in full sentences; only create a JSON object that satisfies the JSON schema specified in the response format. Make sure you follow the JSON standard for the data types and format.

Expand Down
6 changes: 3 additions & 3 deletions packages/gollm/gollm_openai/prompts/interventions_from_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
INTERVENTIONS_FROM_DOCUMENT_PROMPT = """
You are a helpful agent designed to find intervention policies for a given AMR model described in a research paper.
You are a helpful agent designed to find intervention policies described in a research paper for a given AMR model.
For context, intervention policies can include multiple interventions that include only static interventions or dynamic interventions.
Static interventions are applied at a specific point in time and permanently change the value of a specific parameter or state.
Dynamic interventions are applied when the value of a state crosses a threshold value.
Expand All @@ -26,8 +26,8 @@
3. `model_id` id a UUID. If the AMR model has an id, you can use it. Otherwise, you can set as the nil UUID "00000000-0000-0000-0000-000000000000".
4. For each intervention specified in the policy create an intervention object with the following rules.
a. Create a value for `name` from the user-provided text.
b. Determine what page that the majority of information was extracted from and set the `extractionPage` value to that page number. If the page number cannot be determined, set it to 0.
c. create a list of either static or dynamic interventions, but not both. The other list should be empty.
b. Determine what page the information was extracted from and set the `extractionPage` value to that page number. If the page number cannot be determined, set it to 0. Only pick one page number. Do not provide a range.
c. Create a list of either static or dynamic interventions, but not both. The other list should be empty.
i. `appliedTo` should reference the id of a parameter or state in the AMR Model. If you cannot find a state or parameter in the AMR model that matches, do not create an intervention object.
ii. `type` should be either "state" or "parameter" depending on what the intervention is applied to.
iii. For dynamic interventions, `parameter` should be the id of a state that the threshold is applied to.
Expand Down