Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add observables from the model and not model-configuration #6461

Merged
merged 8 commits into from
Feb 7, 2025
Merged

add observables from the model and not model-configuration #6461

merged 8 commits into from
Feb 7, 2025

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Feb 6, 2025 •
edited
Loading

Description

  • We used to add the Observables from the model-configuration and not the model, or only the ones from the model have Groundings.
  • Do some renaming and typing to match that the options for mapping from the model are either State or Observable.
  • Only map concept to the minimum of model variables or dataset fields.

@YohannParis YohannParis marked this pull request as ready for review February 6, 2025 03:48
Tom-Szendrey
Tom-Szendrey approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Tom-Szendrey Tom-Szendrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Base automatically changed from release/v2.31.0 to main February 6, 2025 15:52
@YohannParis YohannParis changed the base branch from main to release/v2.31.0 February 6, 2025 16:19
Base automatically changed from release/v2.31.0 to main February 7, 2025 01:26
@mwdchang mwdchang merged commit 4ed919e into main Feb 7, 2025
@mwdchang mwdchang deleted the add-observables-to-the-auto-mapping branch February 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-Szendrey Tom-Szendrey Tom-Szendrey approved these changes

@dvince2 dvince2 dvince2 approved these changes

@mloppie mloppie mloppie approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YohannParis @Tom-Szendrey @dvince2 @mloppie @mwdchang @dgauldie @shawnyama