refactor: fix a bunch of simple warnings

src/celt/celt_encoder.rs

@@ -430,7 +430,6 @@ unsafe fn compute_mdcts(
     CC: i32,
     LM: i32,
     upsample: i32,
-    arch: i32,
 ) {
     let overlap: i32 = (*mode).overlap;
     let mut N: i32 = 0;
@@ -464,7 +463,7 @@ unsafe fn compute_mdcts(
                 ),
                 std::slice::from_raw_parts_mut(
                     out.offset((b + c * N * B) as isize),
-                    (mdct_n / 2 * B as usize),
+                    mdct_n / 2 * B as usize,
                 ),
                 (*mode).window,
                 overlap as usize,
@@ -2296,7 +2295,6 @@ pub unsafe fn celt_encode_with_ec(
             CC,
             LM,
             (*st).upsample,
-            (*st).arch,
         );
         compute_band_energies(
             mode,
@@ -2331,7 +2329,6 @@ pub unsafe fn celt_encode_with_ec(
         CC,
         LM,
         (*st).upsample,
-        (*st).arch,
     );
     assert!(
         !(*freq.as_mut_ptr().offset(0 as isize) != *freq.as_mut_ptr().offset(0 as isize))
@@ -2574,7 +2571,6 @@ pub unsafe fn celt_encode_with_ec(
                 CC,
                 LM,
                 (*st).upsample,
-                (*st).arch,
             );
             compute_band_energies(
                 mode,

src/celt/modes.rs

@@ -37,10 +37,7 @@ pub mod stddef_h {
 pub mod static_modes_float_h;
 
 pub use self::arch_h::opus_val16;
-pub use self::static_modes_float_h::{
-    cache_bits50, cache_caps50, cache_index50, fft_bitrev120, fft_bitrev240, fft_bitrev480,
-    fft_bitrev60, fft_twiddles48000_960, logN400, static_mode_list, window120,
-};
+pub use self::static_modes_float_h::static_mode_list;
 pub use self::stddef_h::NULL;
 use crate::celt::mdct::mdct_lookup;
 use crate::src::opus_defines::{OPUS_BAD_ARG, OPUS_OK};

src/celt/quant_bands.rs

@@ -109,7 +109,7 @@ static mut e_prob_model: [[[u8; 42]; 2]; 4] = [
         ],
     ],
 ];
-static mut small_energy_icdf: [u8; 3] = [2, 1, 0];
+static small_energy_icdf: [u8; 3] = [2, 1, 0];
 unsafe fn loss_distortion(
     eBands: *const opus_val16,
     oldEBands: *mut opus_val16,

src/celt/vq.rs

@@ -1,5 +1,4 @@
 use crate::celt::bands::SPREAD_NONE;
-use std::f32::consts::PI;
 
 pub mod arch_h {
     pub type opus_val16 = f32;

src/silk/check_control_input.rs

@@ -11,6 +11,9 @@ pub mod errors_h {
     pub const SILK_ENC_FS_NOT_SUPPORTED: i32 = -(102);
 }
 
+// I still am on the fence on whether I should handle user or just panic
+// these should stay until I decide
+#[allow(unused)]
 pub use self::errors_h::{
     SILK_ENC_FS_NOT_SUPPORTED, SILK_ENC_INVALID_CBR_SETTING, SILK_ENC_INVALID_COMPLEXITY_SETTING,
     SILK_ENC_INVALID_DTX_SETTING, SILK_ENC_INVALID_INBAND_FEC_SETTING, SILK_ENC_INVALID_LOSS_RATE,

src/silk/control_codec.rs

@@ -1,9 +1,3 @@
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod errors_h {
     pub const SILK_ENC_PACKET_SIZE_NOT_SUPPORTED: i32 = -(103);
     pub const SILK_NO_ERROR: i32 = 0;
@@ -41,7 +35,6 @@ pub mod typedef_h {
     pub const silk_int16_MAX: i32 = i16::MAX as i32;
 }
 use self::errors_h::{SILK_ENC_PACKET_SIZE_NOT_SUPPORTED, SILK_NO_ERROR};
-pub use self::typedef_h::{silk_int16_MAX, silk_int16_MIN};
 pub use self::SigProc_FLP_h::{silk_float2short_array, silk_short2float_array};
 use crate::externs::memset;
 use crate::silk::control_audio_bandwidth::silk_control_audio_bandwidth;

src/silk/float/find_LPC_FLP.rs

@@ -9,8 +9,6 @@ pub mod typedef_h {
 pub mod internal {
     pub const __FLT_MAX__: f32 = 3.40282347e+38f32;
 }
-pub use self::float_h::FLT_MAX;
-pub use self::internal::__FLT_MAX__;
 pub use self::typedef_h::silk_float_MAX;
 use crate::silk::define::MAX_NB_SUBFR;
 use crate::silk::float::burg_modified_FLP::silk_burg_modified_FLP;

src/silk/float/pitch_analysis_core_FLP.rs

@@ -1,12 +1,6 @@
 pub mod arch_h {
     pub type opus_val32 = f32;
 }
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod SigProc_FLP_h {
     #[inline]
     pub unsafe fn silk_float2short_array(out: *mut i16, in_0: *const f32, length: i32) {

src/silk/float/wrappers_FLP.rs

@@ -1,12 +1,6 @@
 use crate::silk::A2NLSF::silk_A2NLSF;
 use crate::silk::NLSF2A::silk_NLSF2A;
 
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod SigProc_FLP_h {
     #[inline]
     pub unsafe fn silk_float2int(x: f32) -> i32 {

src/silk/resampler/mod.rs

@@ -101,13 +101,6 @@ enum ResamplerMode {
     DownFir(ResamplerDownFirParams, ResamplerDownFirState),
 }
 
-#[derive(Copy, Clone)]
-#[repr(C)]
-pub union sFIR_union {
-    pub i32_0: [i32; SILK_RESAMPLER_MAX_FIR_ORDER],
-    pub i16_0: [i16; SILK_RESAMPLER_MAX_FIR_ORDER],
-}
-
 pub fn silk_resampler_init(Fs_Hz_in: i32, Fs_Hz_out: i32, forEnc: i32) -> ResamplerState {
     let inputDelay = if forEnc != 0 {
         if !matches!(Fs_Hz_in, 8000 | 12000 | 16000 | 24000 | 48000)

src/src/analysis.rs

@@ -66,12 +66,6 @@ pub const ANALYSIS_BUF_SIZE: i32 = 720;
 pub const DETECT_SIZE: i32 = 100;
 pub const NB_FRAMES: i32 = 8;
 pub const NB_TBANDS: i32 = 18;
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod math_h {
     pub const M_PI: f64 = 3.14159265358979323846f64;
 }

src/src/mapping_matrix.rs

@@ -2,13 +2,7 @@ pub mod arch_h {
     pub type opus_val16 = f32;
     pub type opus_val32 = f32;
 }
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
-pub use self::arch_h::{opus_val16, opus_val32};
+use self::arch_h::{opus_val16, opus_val32};
 use crate::celt::float_cast::FLOAT2INT16;
 use crate::src::opus_private::align;
 

src/src/opus_decoder.rs

@@ -8,12 +8,6 @@ pub mod stddef_h {
     pub type size_t = u64;
     pub const NULL: i32 = 0;
 }
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod cpu_support_h {
     #[inline]
     pub unsafe fn opus_select_arch() -> i32 {

src/src/opus_encoder.rs

@@ -12,12 +12,6 @@ pub mod stddef_h {
     pub type size_t = u64;
     pub const NULL: i32 = 0;
 }
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 pub mod cpu_support_h {
     #[inline]
     pub unsafe fn opus_select_arch() -> i32 {

src/src/opus_multistream_decoder.rs

@@ -25,12 +25,6 @@ pub mod stddef_h {
     pub type size_t = u64;
     pub const NULL: i32 = 0;
 }
-pub mod xmmintrin_h {
-    #[cfg(target_arch = "x86")]
-    pub use core::arch::x86::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-    #[cfg(target_arch = "x86_64")]
-    pub use core::arch::x86_64::{__m128, _mm_cvt_ss2si, _mm_cvtss_si32, _mm_set_ss};
-}
 use self::arch_h::opus_val16;
 pub use self::stddef_h::{size_t, NULL};
 use crate::celt::float_cast::FLOAT2INT16;

unsafe-libopus-tools/src/demo/backend.rs

@@ -3,8 +3,8 @@
 
 use ::unsafe_libopus::varargs::VarArgs;
 
-pub struct Encoder([u8; 1]);
-pub struct Decoder([u8; 1]);
+pub struct Encoder(());
+pub struct Decoder(());
 
 pub trait OpusBackend {
     unsafe fn opus_encoder_create(