-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to use axis-aligned geometry for hex/quad/lines in hype… #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the function also expect only 6 boundary coordinates (min x, y, z and max x, y, and z), if the axis-aligned geometry is used?
I just talked with @Davknapp about this PR and also the follow-up PR. I see some general problems with the way this performance feature is introduced into t8code. |
If I remember correctly our discussion was mainly about the follow-up PR (#751). As we construct a cmesh here this PR is not meant to give an improved performance. It is only about the cmesh. The improved performance is introduced in #751. |
I agree. The actual performance improvement is implemented in the follow-up PR (#751). My point is that I want to avoid to introduce your proposed This might mean we should start from scratch and create a new PRs, moving the point-search-operation to the geometry module first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My branch is now merged, and we can use the new geometry query
src/t8_geometry/t8_geometry_implementations/t8_geometry_linear_axis_aligned.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_linear_axis_aligned.h
Outdated
Show resolved
Hide resolved
…_axis_aligned.cxx Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
…_axis_aligned.h Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
…nce_hypercube_pad
…rcube_pad
Added a flag to use the axis-aligned geometrie for faster evaluation for hex/quads/lines
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)