Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use axis-aligned geometry for hex/quad/lines in hype… #747

Merged
merged 34 commits into from
Jan 18, 2024

Conversation

Davknapp
Copy link
Collaborator

…rcube_pad

Added a flag to use the axis-aligned geometrie for faster evaluation for hex/quads/lines

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp added enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins labels Sep 13, 2023
@sandro-elsweijer sandro-elsweijer self-assigned this Sep 13, 2023
src/t8_cmesh/t8_cmesh_examples.h Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
@jmark jmark self-assigned this Sep 18, 2023
Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the function also expect only 6 boundary coordinates (min x, y, z and max x, y, and z), if the axis-aligned geometry is used?

@jmark jmark marked this pull request as draft September 21, 2023 17:10
@jmark
Copy link
Collaborator

jmark commented Sep 21, 2023

I just talked with @Davknapp about this PR and also the follow-up PR. I see some general problems with the way this performance feature is introduced into t8code.

@Davknapp
Copy link
Collaborator Author

I just talked with @Davknapp about this PR and also the follow-up PR. I see some general problems with the way this performance feature is introduced into t8code.

If I remember correctly our discussion was mainly about the follow-up PR (#751). As we construct a cmesh here this PR is not meant to give an improved performance. It is only about the cmesh. The improved performance is introduced in #751.

@jmark
Copy link
Collaborator

jmark commented Sep 22, 2023

I just talked with @Davknapp about this PR and also the follow-up PR. I see some general problems with the way this performance feature is introduced into t8code.

If I remember correctly our discussion was mainly about the follow-up PR (#751). As we construct a cmesh here this PR is not meant to give an improved performance. It is only about the cmesh. The improved performance is introduced in #751.

I agree. The actual performance improvement is implemented in the follow-up PR (#751).

My point is that I want to avoid to introduce your proposed use axis aligned geometry flag to the function signature. I strongly suggest to move the point-search-operation into the geometry module and specialize this for the axis-aligned geometry. Than the performant implementation is used automatically when the cmesh geometry is set to the axis-aligned geometry.

This might mean we should start from scratch and create a new PRs, moving the point-search-operation to the geometry module first.

Copy link
Collaborator

@sandro-elsweijer sandro-elsweijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My branch is now merged, and we can use the new geometry query

src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
src/t8_cmesh/t8_cmesh_examples.c Outdated Show resolved Hide resolved
Davknapp and others added 8 commits November 28, 2023 09:35
…_axis_aligned.cxx

Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
…_axis_aligned.h

Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
@sandro-elsweijer sandro-elsweijer merged commit 4b6e7f0 into main Jan 18, 2024
8 checks passed
@sandro-elsweijer sandro-elsweijer deleted the enhance_hypercube_pad branch January 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants