-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature point inside check for axis aligned geom #751
Feature point inside check for axis aligned geom #751
Conversation
…for_axis_aligned_geom
…xis_aligned_geom' into feature-point_inside_check_for_axis_aligned_geom
had to do some merging, because the diff showed changes which are not actually from this pr |
…for_axis_aligned_geom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…check_for_axis_aligned_geom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review, I am going to eat now
src/t8_geometry/t8_geometry_implementations/t8_geometry_linear_axis_aligned.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_examples.hxx
Outdated
Show resolved
Hide resolved
…check_for_axis_aligned_geom
…check_for_axis_aligned_geom
src/t8_geometry/t8_geometry_implementations/t8_geometry_linear.cxx
Outdated
Show resolved
Hide resolved
src/t8_geometry/t8_geometry_implementations/t8_geometry_zero.hxx
Outdated
Show resolved
Hide resolved
…check_for_axis_aligned_geom
…check_for_axis_aligned_geom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing
Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
Implemented a point inside check that is specialized for axis-aligned geometries.
Also enhanced the gtest to test this feature.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.Licence
doc/
(or already has one)