Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 923 cmesh add attr error #972

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Conversation

holke
Copy link
Collaborator

@holke holke commented Mar 4, 2024

Describe your changes here:

This is related #923 (but does not close)
When deriving a cmesh it is not possible to add an attribute.

This PR introduces an error message and abort when a user tries to do it.
We also add a standalone test case for adding an attribute while deriving.
This test is currently deactivated.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@holke holke added enhancement Enhances already existing code tests labels Mar 4, 2024
holke and others added 3 commits March 4, 2024 14:30
Co-authored-by: David Knapp <david.knapp@dlr.de>
Co-authored-by: David Knapp <david.knapp@dlr.de>
Co-authored-by: David Knapp <david.knapp@dlr.de>
@holke holke enabled auto-merge March 18, 2024 14:19
@holke holke assigned Davknapp and unassigned holke Mar 18, 2024
@Davknapp Davknapp assigned holke and unassigned Davknapp Mar 19, 2024
@holke holke added the next release For the next release label Mar 27, 2024
@holke holke requested a review from Davknapp March 27, 2024 11:44
@holke holke assigned Davknapp and unassigned holke Mar 27, 2024
@holke holke merged commit 6d8644e into main Mar 27, 2024
8 checks passed
@holke holke deleted the feature-923_cmesh_add_attr_error branch March 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code next release For the next release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants