Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of ducts #768

Closed
MarAlder opened this issue Apr 7, 2022 · 5 comments
Closed

Definition of ducts #768

MarAlder opened this issue Apr 7, 2022 · 5 comments

Comments

@MarAlder
Copy link
Collaborator

MarAlder commented Apr 7, 2022 •
edited
Loading

I would like to announce that the TiGL development is currently fokusing on ducts (see DLR-SC/tigl#881), i.e. fuselage-like bodies which are substracted from the aircraft fuselage and wings:

grafik

The work is currently based on the following XSD extension (see duct branch):
grafik

Everyone is invited to contribute to this effort with comments, ideas or identification of possible problems, either here or at DLR-SC/tigl#881.
@joergbrech
Copy link
Contributor

I don't know if this serves any use case, but I was wondering: Would it make sense to have the duct elements on the same level as the ductAssemblys and have the ductAssemblys reference duct elements by uid? That way you could re-use a duct element in more than one duct assembly...

@joergbrech
Copy link
Contributor

@CLiersch @rmaierl @AntonReiswich @sdeinert I just wanted to tag you guys here.

@CLiersch
Copy link

The proposal of @joergbrech sounds as a good idea to me. Imagine two engines sharing a <duct> element.
Then, a <ductAssembly> can be made a continuous line of <duct> elements from intake to outlet for one engine, without specifying the double-used <duct> twice.

joergbrech added a commit to joergbrech/CPACS that referenced this issue Apr 21, 2022
@joergbrech
some modifications in ducts definition
73ce629 
 - ducts element in configuration before fuselage and wing type fixes issue in tigl
 - ducts are defined on the same level as ductAssemblies to make them reusable
 - ductAssemblies reference ducts via UID to make ducts reusable
 - sections element in ductType before segments fixes issue in tigl

addresses DLR-SL#768
@joergbrech joergbrech mentioned this issue Apr 21, 2022
Closed
@joergbrech
Copy link
Contributor

The proposal of @joergbrech sounds as a good idea to me. Imagine two engines sharing a element.
Then, a can be made a continuous line of elements from intake to outlet for one engine, without specifying the double-used twice.

We changed the definition in #774 accordingly and used this as a basis for our implementation in TiGL.

@jnwalther jnwalther mentioned this issue Jun 29, 2022
Open
3 tasks
@MarAlder
Copy link
Collaborator Author

MarAlder commented Aug 7, 2023

Implemented

@MarAlder MarAlder closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CPACS 3.5
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CLiersch @joergbrech @MarAlder