Some modifications in ducts definition #774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ducts element in configuration before fuselage and wing type fixes issue in tigl - ducts are defined on the same level as ductAssemblies to make them reusable - ductAssemblies reference ducts via UID to make ducts reusable - sections element in ductType before segments fixes issue in tigl addresses DLR-SL#768
Closed
|
Having some difficulties in resolving conflicts. I manually aligned with your implementation via 00d643d and will close this merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the implementation of ducts in TiGL (DLR-SC/tigl#889) we made some modifications in the current ducts definition. Firstly, we now have
ducts andductAssemblys at the same level under theductsTypeandductAssemblys reference aductvia UID. This way,ducts can be reused by more than oneductAssembly. Finally, we reordered the elements in twoxsd:allelements to fix some issues with the order of reading the CPACS files via the routines provided by https://github.com/RISCSoftware/cpacs_tigl_gen.Concretely,
addresses #768