Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark module as Azure compatible #43

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jan 9, 2019

There's a warning when installing the module on an Azure SQL database, though it works just fine

There's a warning when installing the module on an Azure SQL database, though it works just fine
@ghost
Copy link

ghost commented Jan 14, 2019

Brian, I've just opened #44 which will make some changes to the database, including some stored procedure utilisation. I've no reason to think that these changes would mean Azure SQL incompatibility however would you mind pulling those changes in once they've been merged and testing again?

@bdukes
Copy link
Contributor Author

bdukes commented Jan 15, 2019

Thanks for the heads up @can-anierzad. I'm trying to produce a package to test with, but I'm either running the wrong command or can't find where it's being generated. Can you let me know the best way to generate that install package?

@ghost
Copy link

ghost commented Jan 16, 2019

@bdukes you should just be able to run a build in the Release configuration within Visual Studio. The install zip will be output to a CompiledModules folder in the folder above your repo.

|- CompiledModules
  |-Cantarus.Modules.PolyDeploy_00.09.01_Install.zip
|- PolyDeploy
  |- DeployClient
  |- PolyDeploy
  |- PolyDeploy.sln
  ...

I hope that makes sense.

@bdukes
Copy link
Contributor Author

bdukes commented Jan 16, 2019

Thanks @can-anierzad, I found the package once I knew the name/location of that folder.

All of the SQL ran just fine after I was able to get the module setup (getting it setup was a bit of a pain, which I'll mention in #44)

@bdukes bdukes mentioned this pull request Jan 16, 2019
@bdukes
Copy link
Contributor Author

bdukes commented Apr 30, 2020

Anything needed before this gets merged? Any plans for timing on the next release?

@mitchelsellers mitchelsellers merged commit 99fffb4 into DNNCommunity:development Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants