Data obfuscation

[ghost]

This feature obfuscates the data stored within the APIUsers and IPSpecs tables of PolyDeploy. This prevents either of these tables being easily manipulated through the database.

More importantly, we no longer store any useful information about an APIUser in an un-hashed or unencrypted form. The user's encryption key is encrypted using their api key their api key is salted and hashed before being stored in the database. With this approach the information needed to read a user's encryption key is not stored.

[StevenFisherCantarus]

I've taken a very general high level look and it all makes sense to me, I'll let Martin have a say based on his more detailed look.

[ghost]

Looks good to me, I've requested a few minor formatting changes. But on the whole looks like a good step forward in obfuscating the API clients and IP whitelist at rest.

[ghost]

Can you document this method please, particularly the string formatting for the bytes to fixed width hexadecimal format.

[ghost]

Method documented.

[ghost]

I think using the this keyword here would make it clear that these are private fields as opposed to local variables.

[HaGGi13]

Just a suggestion:
It's a good practice to avoid the usage of this, but then a naming convention should be used. Approximately all projects in which I was involved we used an leading _ (underscore) for instance variables. It results in a great visible difference between local and instance variables in a class without using this.

[ghost]

Please add semicolons to the end of each SQL Statement, like so:

DECLARE @ConstraintName [VARCHAR](128);

SET @ConstraintName = (...);

IF (@ConstraintName IS NOT NULL)
    BEGIN
        EXEC('...');
    END

It is particularly unclear to read later on in this file where you're doing several ALTER TABLE clauses within a conditional block.

[bdukes]

I installed this on an Azure test site for #43, and wasn't able to use it because of the IP whitelist. Previously, I would use the DNN SQL console to insert the IP address into the whitelist, but now that it's hashed I can't. I ended up having to uninstall, install PolyDeploy 0.8.0, add the IP address into the database, and then upgrade to 0.9.1 (the upgrade went off without a hitch, kudos 😄).

All of that to say, is it time to revisit #24 and remove IP whitelisting from the UI altogether?

[mitchelsellers]

I can confirm @bdukes Concerns

[ghost]

@bdukes Thanks for the kudos on the upgrade, I won't say it was a quick thing to implement haha.

Hopefully I can ease your concern with the news that as part of v1.0.0 (along with this obfuscation work) I'm planning to add the ability to disable the IP whitelisting entirely and set it to be disabled by default. It will however, give you a large warning in both the management and deployment UI's reminding you that it's switched off.

[bdukes]

👍 perfect