DawnVIR Driver #566
Merged
DawnVIR Driver #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
acpaquette
reviewed
Sep 27, 2023
amystamile-usgs
force-pushed
the
DawnVIR
branch
from
c6e659a to
baf94ac
Compare
amystamile-usgs
force-pushed
the
DawnVIR
branch
from
f3393bb to
f542b4e
Compare
acpaquette
reviewed
Dec 14, 2023
|
Could we also add a changelog entry? |
|
@acpaquette test_vir_load failing. |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 16.17% 15.82% -0.36%
==========================================
Files 56 56
Lines 6144 6283 +139
==========================================
Hits 994 994
- Misses 5150 5289 +139 ☔ View full report in Codecov by Sentry. |
acpaquette
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebook is currently generating an ISD but still need to handle this line from the camera model https://github.com/DOI-USGS/ISIS3/blob/dev/isis/src/dawn/objs/DawnVirCamera/DawnVirCamera.cpp#L385C2-L386C80