feat(monitoring): Filter active sessions by session variables #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit a7014db. |
MoritzWeber0
changed the title
Filter active sessions by tool, tool version, connection method and session type. The value are available as annotations on the Kubernetes service, deployment and pod. Prometheus relabels the annotations to labels. In Grafana, a dropdown menu allows filtering. In addition, the dashboard also shows sessions with failed activity monitoring.
MoritzWeber0
force-pushed
the
session-annotations
branch
from
25e082d to
da1c8c8
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=======================================
Coverage 79.04% 79.05%
=======================================
Files 172 172
Lines 5766 5767 +1
Branches 665 665
=======================================
+ Hits 4558 4559 +1
Misses 1054 1054
Partials 154 154 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
added a commit
that referenced
this pull request
May 28, 2024
The automatic termination of idle sessions stopped working with #1573. Reason is that the app label was removed from Prometheus. This commit migrates the old app references to the new session_id label.
MoritzWeber0
added a commit
that referenced
this pull request
May 28, 2024
Unfortunately, #1573 was merged in an incomplete state due to a missing push. This commit adds the missing changes so that the dashboard works as described in the PR.
MoritzWeber0
added a commit
that referenced
this pull request
May 28, 2024
Unfortunately, #1573 was merged in an incomplete state due to a missing push. This commit adds the missing changes so that the dashboard works as described in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter active sessions by tool, tool version, connection method and session type.
The values are available as annotations on the Kubernetes service, deployment and pod. Prometheus relabels the annotations to labels.
In Grafana, a dropdown menu allows filtering:
In addition, the dashboard also shows sessions with failed activity monitoring.
Also, a small bug that tools couldn't be updated without the ID attribute is fixed.