Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitoring): Fetching of variables in "Active Sessions" dashboard #1589

Merged
merged 1 commit into from
May 28, 2024

Conversation

MoritzWeber0
Copy link
Member

Unfortunately, #1573 was merged in an incomplete state due to a missing push. This PR adds the missing changes so that the dashboard works as described in the PR.

Copy link

github-actions bot commented May 28, 2024

A Storybook preview is available for commit 1de3559.
View Storybook
View Chromatic build

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.65%. Comparing base (da1c8c8) to head (0b50400).
Report is 160 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
+ Coverage   79.05%   79.65%   +0.59%     
==========================================
  Files         172      186      +14     
  Lines        5767     6762     +995     
  Branches      665      885     +220     
==========================================
+ Hits         4559     5386     +827     
- Misses       1054     1201     +147     
- Partials      154      175      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Unfortunately, #1573 was merged in an incomplete state due to a missing push.
This commit adds the missing changes so that the dashboard works as described in the PR.
@MoritzWeber0 MoritzWeber0 force-pushed the session-annotations branch from 7dbcea5 to 0b50400 Compare May 28, 2024 12:10
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 221ac2e into main May 28, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the session-annotations branch May 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant