Nested LoggerChain DoctrineSubscriber

[oleg-andreyev]

Q	A
auditor version	2.x
PHP version	8.1
Database	MySQL

Summary

<?php

namespace DH\Auditor\Tests\Provider\Doctrine\Event;

use DH\Auditor\Provider\Doctrine\Auditing\Event\DoctrineSubscriber;
use DH\Auditor\Provider\Doctrine\Auditing\Logger\LoggerChain;
use DH\Auditor\Provider\Doctrine\Auditing\Transaction\TransactionManager;
use Doctrine\DBAL\Configuration;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Driver;
use Doctrine\DBAL\Logging\SQLLogger;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Event\OnFlushEventArgs;
use Doctrine\Persistence\ObjectManager;
use PHPUnit\Framework\TestCase;

class DoctrineSubscriberTest extends TestCase
{
    public function testMemoryUsage(): void
    {
        $transactionManager = $this->createMock(TransactionManager::class);
        $objectManager = $this->createMock(EntityManagerInterface::class);

        $args = new OnFlushEventArgs($objectManager);

        $objectManager
            ->method('getConnection')
            ->willReturn($connection = $this->createMock(Connection::class));

        $connection
            ->method('getDriver')
            ->willReturn($driver = $this->createMock(Driver::class));

        $connection
            ->method('getConfiguration')
            ->willReturn($configuration = new Configuration());

        $configuration->setSQLLogger(new class implements SQLLogger {
            public function startQuery($sql, ?array $params = null, ?array $types = null)
            {
            }

            public function stopQuery()
            {
            }
        });

        $target = new DoctrineSubscriber($transactionManager);
        $target->onFlush($args);
        $target->onFlush($args);
        $target->onFlush($args);
        $target->onFlush($args);
        $target->onFlush($args);

        $result = $configuration->getSQLLogger();
        self::assertCount(2, $result->getLoggers());
    }
}

Current behavior

Failed asserting that actual size 6 matches expected size 2.

Expected behavior

There should be only two logger, native and AuditLogger

[oleg-andreyev]

result of internal fixes

vs

[DamienHarper]

@oleg-andreyev, thanks for the report and the relevant PR.
Fixed in 2.x branch. I'll make a new release asap.

[DamienHarper]

@oleg-andreyev 2.4.8 is available