Fix bug: exception while creating audit table schema when using single table inheritance #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #133 +/- ##
==========================================
- Coverage 93.05% 92.31% -0.74%
==========================================
Files 44 44
Lines 1526 1510 -16
==========================================
- Hits 1420 1394 -26
- Misses 106 116 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@DamienHarper please take a look, since I have the same issue in the latest release. |
DamienHarper
requested changes
Dec 2, 2022
There was a problem hiding this comment.
Thanks again @dmitryuk for this PR.
I started working on version 3.0.0 in master branch a few days ago (it will drop PHP 7.4 support, Symfony 4.x support etc.)
I also created a 2.x branch since I started working on 3.0 so, could you target this PR to 2.x branch please?
I'll backport the fix to master branch once merged and released as 2.3.1
Done |
|
Don't understand why Github workflow not run after push |
DamienHarper
approved these changes
Dec 2, 2022
Fixed now but CI is failing now |
|
CI should be ok now |
DamienHarper
added a commit
that referenced
this pull request
Dec 2, 2022
* Fix bug: exception while creating audit table schema when using single table inheritance (#133) * fix #132 * entity Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com> * Fixed annotations in tests * Removed annotations from cherrypicked commits Co-authored-by: Alexander Dmitryuk <xakzona@bk.ru> Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com>
DamienHarper
added a commit
that referenced
this pull request
Jul 14, 2024
* Fix bug: exception while creating audit table schema when using single table inheritance (#133) * fix #132 * entity Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com> * Updated README.md * Updated CI * Fixed annotations in tests * Regression fix. Fixes DamienHarper/auditor-bundle#334 * Updated CI * Performance issues with metadatas (#137) * Cache DH Annotations * speed * remove getOwner call Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com> * CreateSchemaListener not updating inheritance tables (#139) * Fix: Attempted to call an undefined method named "getMetadataCache" of class "Doctrine\ORM\Configuration". (#144) * Fix: Attempted to call an undefined method named "introspectSchema" of class "Doctrine\DBAL\Schema\PostgreSQLSchemaManager" (#143) * Fixed invokable storage mapper (see #146) (#148) * Fixed broken annotation registration since doctrine/orm 2.14 * improved the TransactionProcessor to convert encoding of diff properly (#152) * improved the TransactionProcessor to convert encoding of diff properly * adapted quotes in TransactionProcessor to single quotes * Fixed compatibility issue with doctrine/event-manager ^2.0 (#157) * PHP-CS-Fixer * Validate that diff is a string before passing to mb_convert_encoding (#156) * PHP-CS-Fixer * Support doctrine annotations 2.0 (#158) * topic 344 doctrine annotations 2.0 --------- Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com> * PHP-CS-Fixer * Fix failing CI (lock related) * PHP-CS-Fixer * Fixes `diffs` column type when JSON type is supported * Fixed CI (2.x) * Fixed CI (2.x) * Fixed CI (2.x) * Fixed CI (2.x) * Fixed CI (2.x) * Fix 185 (#186) * fixes #185 * PHP-CS-Fixer --------- Co-authored-by: Damien Harper <damien.harper@gmail.com> * skip embedded class from schema listener (#189) Co-authored-by: Guillaume Sainthillier <guillaume.sainthillier@gmail.com> * Fixed CI (2.x) * Typo * PHP-CS-Fixer * Update deps + PHP-CS-Fixer * PHP-CS-Fixer * PHP-CS-Fixer (3.48.0) * Detected wrapped driver (#195) * - updated DHDriver and use parent::connect instead of dedicated field - added getWrappedDriver to extract wrapped driver. - tests Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * Fixed PHPStan error --------- Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> Co-authored-by: Damien Harper <damien.harper@gmail.com> * fix Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * php-cs-fixer Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * removed getSubscribedEvents from CreateSchemaListener Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * phpstan Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * fix DoctrineSubscriber + tests Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * fix Issue174Test Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> * removed duplicate code, fixed test Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> --------- Signed-off-by: Oleg Andreyev <oleg@andreyev.lv> Co-authored-by: Alexander Dmitryuk <xakzona@bk.ru> Co-authored-by: a.dmitryuk <a.dmitryuk@movavi.com> Co-authored-by: damienharper <damien.harper@gmail.com> Co-authored-by: Jörn Dyherrn <joern@dyherrn.dev> Co-authored-by: Martijn Boers <2955898+martijnboers@users.noreply.github.com> Co-authored-by: Guillaume Sainthillier <guillaume.sainthillier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132