Webpack

[bbert]

Migrate bundler to webpack.
What has been done:

• replace grunt by webpack
• replace jshint by eslint
• add dev task for watch mode
• add start task for running dev server with watch mode and hot reloading
• generate only minified files (with source maps) in build task
• add files section in package.json in order to publish only dist folder

To complete:

• publish files on ftp server
• update precommit git hook (@dsilhavy where git hooks are configured for this repo for all users?)

[mlasak]

Removing the condition "${CIRCLE_BRANCH}" = "development" would result in having builds from any branch deployed via ftp as circle ci builds happen on any branch. Most of those deployment would be not desired in most cases (feature branches would overwrite the "nightly build"). Only from one agreed on branch deployments should happen (currently this was/is "development").

Btw, sorry, i owe you all some docu/howto on circle ci config ;)

[bbert]

This was done temporarily to check ftp push feature in this branch .
This will restore before being merged

[mlasak]

ok, i'll keep this one open so we do not forget..

[mlasak]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)

I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint

What do you think about this approach @bbert ?

@dsilhavy fyi

[bbert]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)

I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint

What do you think about this approach @bbert ?

@dsilhavy fyi

Fine, I prefer this approach (postinstall)

[bbert]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)
I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint
What do you think about this approach @bbert ?
@dsilhavy fyi

Fine, I prefer this approach (postinstall)

Have you sublmitted this code in any PR?

Yes i've submitted this PR #3253 . But is still not merged :(
How would you like to proceed on this?

We can merge yours first, then I will update ts PR

[mlasak]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)
I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint
What do you think about this approach @bbert ?
@dsilhavy fyi

Fine, I prefer this approach (postinstall)

Have you sublmitted this code in any PR?

Yes i've submitted this PR #3253 . But is still not merged :(
How would you like to proceed on this?

We can merge yours first, then I will update ts PR

Ok, cool. I will pull out this out of the huge PR and make a separate/specific PR. This makes things faster.

[mlasak]

@bbert pls put: Update README.md to the "To complete:"-List ;) All this grunt stuff needs to be removed there

[mlasak]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)
I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint
What do you think about this approach @bbert ?
@dsilhavy fyi

Fine, I prefer this approach (postinstall)

Have you sublmitted this code in any PR?

Yes i've submitted this PR #3253 . But is still not merged :(
How would you like to proceed on this?

We can merge yours first, then I will update ts PR

Ok, cool. I will pull out this out of the huge PR and make a separate/specific PR. This makes things faster.

@bbert As discussed, we have merged the git hook creation script and the postinstall instruction into development.
I think only thing you need now to do is base ontop of development and then change the githook.js script to run npm run lint instead the current grunt lint call.

[bbert]

@bbert, until now githooks were added by module grunt-githooks. This module modifies the local file .git/hooks/pre-commit (pls have a look in yours locally)
I fully support removing this outdated module as dep, so i tried to implement this functionality already as postinstall node script in
9483b0c
But, instead of using grunt lint it should call npm run lint
What do you think about this approach @bbert ?
@dsilhavy fyi

Fine, I prefer this approach (postinstall)

Have you sublmitted this code in any PR?

Yes i've submitted this PR #3253 . But is still not merged :(
How would you like to proceed on this?

We can merge yours first, then I will update ts PR

Ok, cool. I will pull out this out of the huge PR and make a separate/specific PR. This makes things faster.

@bbert As discussed, we have merged the git hook creation script and the postinstall instruction into development.
I think only thing you need now to do is base ontop of development and then change the githook.js script to run npm run lint instead the current grunt lint call.

OK thanks I'll do it

[bbert]

@mlasak I updated script githooks.js, please check.

[mlasak]

this last changes lgtm

[mlasak]

PR lgtm