Promotion 2024-10-16 prod (#6571)

[dsotirho-ucsc]

Connected issue: #6571

Checklist

Author

• Target branch is prod
• Name of PR branch matches promotions/yyyy-mm-dd-prod
• On ZenHub, PR is connected to the promotion issue it resolves
• PR description links to connected issue
• Title of connected issue matches Promotion yyyy-mm-dd
• PR title starts with title of connected issue followed by prod
• PR title references the connected issue

Author (reindex, API changes)

• This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
• This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod _{or requires a full reindex or is not labeledreindex:prod}

Author (upgrading deployments)

• This PR is labeled upgrade _{or does not require upgrading deployments}
• This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
• This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
• This PR is labeled deploy:runner _{or does not require deploying the runner image}

System administrator (after approval)

• Actually approved the PR
• Labeled PR as no sandbox
• Moved connected issue to Approved column
• PR is assigned to only the operator

Operator (before pushing merge the commit)

• Pushed PR branch to GitHub
• Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply _{or this PR is not labeled deploy:shared}
• Made a backup of the GitLab data volume in prod (see operator manual for details) _{or this PR is not labeled backup:gitlab}
• Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
• Checked the items in the next section _{or this PR is labeled deploy:gitlab}
• PR is assigned to only the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator

• Background migrations for prod.gitlab are complete _{or this PR is not labeled deploy:gitlab}
• PR is assigned to only the operator

Operator (before pushing merge the commit)

• Ran _select prod.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
• The title of the merge commit starts with the title of this PR
• Added PR # reference to merge commit title
• Collected commit title tags in merge commit title _{but excluded any p tags}
• Pushed merge commit to GitHub

Operator (after pushing the merge commit)

• Pushed merge commit to GitLab prod
• Build passes on GitLab prod
• Reviewed build logs for anomalies on GitLab prod
• Deleted PR branch from GitHub
• Moved connected issue to Merged stable column on ZenHub
• Moved promoted issues from Merged lower to Merged stable column on ZenHub
• Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

• Deindexed all unreferenced catalogs in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
• Deindexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
• Indexed specific sources in prod _{or this PR is neither labeled reindex:partial nor reindex:prod}
• Started reindex in prod _{or this PR does not require reindexing prod}
• Checked for, triaged and possibly requeued messages in both fail queues in prod _{or this PR does not require reindexing prod}
• Emptied fail queues in prod _{or this PR does not require reindexing prod}

Operator

• PR is assigned to only the system administrator

System administrator

• Removed unused image tags from pycharm image on DockerHub _{or this promotion does not alter references to that image}
• Removed unused image tags from elasticsearch image on DockerHub _{or this promotion does not alter references to that image}
• Removed unused image tags from bigquery_emulator image on DockerHub _{or this promotion does not alter references to that image}
• PR is assigned to no one

Shorthand for review comments

• L line is too long
• W line wrapping is wrong
• Q bad quotes
• F other formatting problem

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (a08f86c) to head (6e485c1).

Files with missing lines	Patch %	Lines
src/azul/terraform.py	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             prod    #6573      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.02%     
==========================================
  Files         155      155              
  Lines       20960    20739     -221     
==========================================
- Hits        17898    17707     -191     
+ Misses       3062     3032      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coveralls]

coverage: 85.397% (-0.002%) from 85.399%
when pulling 6e485c1 on promotions/2024-10-16-prod
into a08f86c on prod.