Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of our integration tests has started failing on unrelated PRs #2873

Closed
adamnovak opened this issue Nov 21, 2019 · 0 comments · Fixed by #2874
Closed

One of our integration tests has started failing on unrelated PRs #2873

adamnovak opened this issue Nov 21, 2019 · 0 comments · Fixed by #2874
Assignees

Comments

@adamnovak
Copy link
Member

adamnovak commented Nov 21, 2019

The Python 2 integration tests are failing with this:

_____ AWSJobStoreTest.test_testImportSharedFile__otherCls_filejobstoretest _____
Traceback (most recent call last):
  File "/builds/databiosphere/toil/src/toil/test/jobStores/jobStoreTest.py", line 124, in setUp
    self.jobstore_initialized.initialize(self.config)
  File "/builds/databiosphere/toil/src/toil/jobStores/aws/jobStore.py", line 148, in initialize
    super(AWSJobStore, self).initialize(config)
  File "/builds/databiosphere/toil/src/toil/jobStores/abstractJobStore.py", line 146, in initialize
    self.writeConfig()
  File "/builds/databiosphere/toil/src/toil/jobStores/abstractJobStore.py", line 154, in writeConfig
    pickle.dump(self.__config, fileHandle, pickle.HIGHEST_PROTOCOL)
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/builds/databiosphere/toil/src/toil/jobStores/aws/jobStore.py", line 552, in writeSharedFileStream
    yield writable
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/builds/databiosphere/toil/src/toil/jobStores/aws/jobStore.py", line 1122, in uploadStream
    assert bool(self.version) == (self.content is None)
AssertionError

This affects #2869 and #2872. I think there is something wrong with the code as it exists in master; AWS may have changed behavior.

┆Issue is synchronized with this Jira Task
┆Issue Number: TOIL-462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant