-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constantly reload Kubernetes config #2869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DailyDreaming I got what I think is an unrelated test failure from the Python 2 integration tests:
I'm going to rerun the test, but we also might have a bug. |
This was referenced Nov 21, 2019
eb71238
to
9508391
Compare
…he credentials are even a little old
9508391
to
5ac5af6
Compare
DailyDreaming
requested changes
Dec 20, 2019
DailyDreaming
approved these changes
Dec 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
DailyDreaming
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Refresh Kubernetes credentials if we want to talk to Kubernetes and the credentials are even a little old * Use a with to clearly close our namespace file
DailyDreaming
pushed a commit
that referenced
this pull request
Feb 13, 2020
* Refresh Kubernetes credentials if we want to talk to Kubernetes and the credentials are even a little old * Use a with to clearly close our namespace file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (written on top of #2868) will fix #2867 by reloading the Kubernetes config and making a new API clients every 5 minutes, as suggested in kubernetes-client/python#741 (comment).
We'll still get in trouble if we have a single watch or loop over pods that runs for more than the credential expiration time, but that seems unlikely to happen and would be its own slowness problem anyway.