Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊[RUMF-257] rework logging #261

Merged
merged 2 commits into from
Feb 11, 2020
Merged

🔊[RUMF-257] rework logging #261

merged 2 commits into from
Feb 11, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 11, 2020

  • remove unneeded info
  • ease logs search/reading
  • track load event with a listener to compare with other timing sources that can be updated

@bcaudan bcaudan requested a review from a team as a code owner February 11, 2020 09:53
@codecov-io
Copy link

Codecov Report

Merging #261 into master will increase coverage by 0.39%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   85.39%   85.79%   +0.39%     
==========================================
  Files          24       24              
  Lines        1315     1316       +1     
  Branches      277      275       -2     
==========================================
+ Hits         1123     1129       +6     
+ Misses        192      187       -5
Impacted Files Coverage Δ
packages/rum/src/rum.ts 81.92% <0%> (ø) ⬆️
packages/rum/src/viewTracker.ts 90.54% <70%> (-3.99%) ⬇️
packages/rum/src/rum.entry.ts 71.42% <0%> (+2.04%) ⬆️
packages/core/src/requestCollection.ts 96.15% <0%> (+13.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb1801...f5cbc88. Read the comment docs.

@bcaudan bcaudan merged commit 1162d5a into master Feb 11, 2020
@bcaudan bcaudan deleted the bcaudan/long-timing-log branch February 11, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants