Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔊[RUMF-257] rework logging #261

Merged
merged 2 commits into from
Feb 11, 2020
Merged

🔊[RUMF-257] rework logging #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1136388
:loud_sound:[RUMF-257] rework logging
bcaudan Feb 11, 2020
f5cbc88
:loud_sound:[RUMF-257] track load event with listener
bcaudan Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/rum/src/rum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,9 @@ export function handleLongTaskEntry(entry: PerformanceLongTaskTiming, addRumEven

function reportAbnormalPerformanceNow() {
if (performance.now() > 300e3 /* 5 min in ms*/) {
addMonitoringMessage(`Abnormal performance.now()
performance.now(): ${performance.now()}
Date.now(): ${Date.now()}
addMonitoringMessage(`[RUMF-257] Abnormal performance.now()
performance.now(): ${performance.now() / 6e4}s
Date.now(): ${new Date().toISOString()}
Navigation entries: ${JSON.stringify(performance.getEntriesByType('navigation'), undefined, 2)}
`)
}
Expand Down
42 changes: 21 additions & 21 deletions packages/rum/src/viewTracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export let viewContext: ViewContext

const THROTTLE_VIEW_UPDATE_PERIOD = 3000
const pageOrigin = Date.now()
const navigationEntries: PerformanceNavigationTiming[] = []
let pageLoad = 0
let startTimestamp: number
let startOrigin: number
let documentVersion: number
Expand All @@ -45,9 +45,15 @@ export function trackView(

newView(location, session, upsertRumEvent)
trackHistory(location, session, upsertRumEvent)
trackMeasures(lifeCycle, scheduleViewUpdate)
trackMeasures(lifeCycle, scheduleViewUpdate, session)
trackRenewSession(location, lifeCycle, session, upsertRumEvent)

window.addEventListener('load', trackLoad)
function trackLoad() {
pageLoad = performance.now()
window.removeEventListener('load', trackLoad)
}

beforeFlushOnUnload(() => updateView(upsertRumEvent))
}

Expand Down Expand Up @@ -120,34 +126,29 @@ function areDifferentViews(previous: Location, current: Location) {
return previous.pathname !== current.pathname
}

function reportAbnormalLoadEvent(navigationEntry: PerformanceNavigationTiming) {
if (
navigationEntry.loadEventEnd > 86400e3 /* one day in ms */ ||
navigationEntry.loadEventEnd > performance.now() + 60e3 /* one minute in ms */
) {
function reportAbnormalLoadEvent(navigationEntry: PerformanceNavigationTiming, session: RumSession) {
if (navigationEntry.loadEventEnd > 36e5 /* one hour in ms */) {
addMonitoringMessage(
`Got an abnormal load event in a PerformanceNavigationTiming entry!
Session Id: ${viewContext.sessionId}
`[RUMF-257] abnormal load event
isTracked: ${session.isTracked()}
Session Id: ${session.getId()}
View Id: ${viewContext.id}
Load event: ${navigationEntry.loadEventEnd}
Page start date: ${pageOrigin}
View start date: ${startTimestamp}
Page duration: ${performance.now()}
View duration: ${performance.now() - startOrigin}
Document Version: ${documentVersion}
Load event (entry): ${navigationEntry.loadEventEnd / 6e4}min
Load event (listener): ${pageLoad / 6e4}min
Page duration (Date.now()): ${(Date.now() - pageOrigin) / 6e4}min
Page duration (perf.now()): ${performance.now() / 6e4}min
Entry: ${JSON.stringify(navigationEntry)}
Previous navigation entries: ${JSON.stringify(navigationEntries)}
Perf timing: ${JSON.stringify(performance.timing)}
Previous measures: ${JSON.stringify(viewMeasures)}`
Previous navigation entries: ${JSON.stringify(performance.getEntriesByType('navigation'))}
Perf timing: ${JSON.stringify(performance.timing)}`
)
}
}

function trackMeasures(lifeCycle: LifeCycle, scheduleViewUpdate: () => void) {
function trackMeasures(lifeCycle: LifeCycle, scheduleViewUpdate: () => void, session: RumSession) {
lifeCycle.subscribe(LifeCycleEventType.PERFORMANCE_ENTRY_COLLECTED, (entry) => {
if (entry.entryType === 'navigation') {
const navigationEntry = entry as PerformanceNavigationTiming
reportAbnormalLoadEvent(navigationEntry)
reportAbnormalLoadEvent(navigationEntry, session)
viewMeasures = {
...viewMeasures,
domComplete: msToNs(navigationEntry.domComplete),
Expand All @@ -156,7 +157,6 @@ function trackMeasures(lifeCycle: LifeCycle, scheduleViewUpdate: () => void) {
loadEventEnd: msToNs(navigationEntry.loadEventEnd),
}
scheduleViewUpdate()
navigationEntries.push(navigationEntry)
} else if (entry.entryType === 'paint' && entry.name === 'first-contentful-paint') {
const paintEntry = entry as PerformancePaintTiming
viewMeasures = {
Expand Down