Change view logic to emit LifeCycle events #366

BenoitZugmeyer · 2020-04-17T14:56:27Z

Motivation: use lifecycle events to create new user actions.

This commit takes a different approach on fixing the session id used when sending RUM events right before the session is renewed. Originally, it was fixed in commit 7bc0dfb by storing the session id into the current view. Since the view was recreated when the session was renewed, events sent during a view were guaranteed to have the same session id than the view. The problem with this approach was that the sessionId was unexpectedly stored in the view context, making different parts of the code dependendent to the view logic. This new solution goal is to be more explicit, and simplify the view logic. The current session id (and type) is kept into the rumSession module, to ensure a consistency accross the RUM library. A new lifeCycle event is sent when the view is about to be renewed, but the session id is still the same.

The view logic will be changed to emit lifeCycle events. Like other component emiting lifeCycle events, name the file as "xxCollection"

This change is a first step to decouple the view logic from the Batch implementation.

packages/rum/src/rumSession.ts

packages/core/src/transport.ts

packages/rum/src/viewCollection.ts

This reverts commit 75eb286. For now, keep the current way we handle session into RUM. We will reconsider this in a future PR.

BenoitZugmeyer · 2020-04-20T14:19:51Z

OK I reverted all session changes, and went back to the viewContext.sessionId for now. Things may be changed in a future PR.

packages/rum/src/lifeCycle.ts

packages/rum/src/viewCollection.ts

This reverts commit 692e9c5.

BenoitZugmeyer requested a review from a team as a code owner April 17, 2020 14:56

BenoitZugmeyer force-pushed the benoit/view-collected-event branch from ceef0eb to c4c1dc2 Compare April 17, 2020 15:07

BenoitZugmeyer added 4 commits April 17, 2020 17:47

🚚 [RUM] rename file viewTracker to viewCollection

601d9c9

The view logic will be changed to emit lifeCycle events. Like other component emiting lifeCycle events, name the file as "xxCollection"

[RUM] use a lifeCycle event for document unload

40216df

This change is a first step to decouple the view logic from the Batch implementation.

[RUM] change viewCollection to emit lifeCycle events

1a1ecf1

BenoitZugmeyer force-pushed the benoit/view-collected-event branch from c4c1dc2 to 1a1ecf1 Compare April 17, 2020 15:48

glorieux reviewed Apr 20, 2020

View reviewed changes

packages/rum/src/rumSession.ts Outdated Show resolved Hide resolved