Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change view logic to emit LifeCycle events #366

Merged
merged 14 commits into from
Apr 21, 2020

Commits on Apr 17, 2020

  1. [RUM] remove session handling in view logic

    This commit takes a different approach on fixing the session id used
    when sending RUM events right before the session is renewed.
    
    Originally, it was fixed in commit
    7bc0dfb by storing the session id into
    the current view.  Since the view was recreated when the session was
    renewed, events sent during a view were guaranteed to have the same
    session id than the view.
    
    The problem with this approach was that the sessionId was unexpectedly
    stored in the view context, making different parts of the code
    dependendent to the view logic.
    
    This new solution goal is to be more explicit, and simplify the view
    logic. The current session id (and type) is kept into the rumSession
    module, to ensure a consistency accross the RUM library. A new lifeCycle
    event is sent when the view is about to be renewed, but the session id
    is still the same.
    BenoitZugmeyer committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    75eb286 View commit details
    Browse the repository at this point in the history
  2. 🚚 [RUM] rename file viewTracker to viewCollection

    The view logic will be changed to emit lifeCycle events. Like other
    component emiting lifeCycle events, name the file as "xxCollection"
    BenoitZugmeyer committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    601d9c9 View commit details
    Browse the repository at this point in the history
  3. [RUM] use a lifeCycle event for document unload

    This change is a first step to decouple the view logic from the Batch
    implementation.
    BenoitZugmeyer committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    40216df View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a1ecf1 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Configuration menu
    Copy the full SHA
    c09fe0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d48afc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    830877c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37a5ecf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8f51855 View commit details
    Browse the repository at this point in the history
  6. ◀👌 [RUM] revert the session changes and adjust tests

    This reverts commit 75eb286.
    
    For now, keep the current way we handle session into RUM.  We will
    reconsider this in a future PR.
    BenoitZugmeyer committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    92d3a52 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Configuration menu
    Copy the full SHA
    7f1f594 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed84961 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0dbc153 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    64d5452 View commit details
    Browse the repository at this point in the history