-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change view logic to emit LifeCycle events #366
Merged
Merged
Commits on Apr 17, 2020
-
[RUM] remove session handling in view logic
This commit takes a different approach on fixing the session id used when sending RUM events right before the session is renewed. Originally, it was fixed in commit 7bc0dfb by storing the session id into the current view. Since the view was recreated when the session was renewed, events sent during a view were guaranteed to have the same session id than the view. The problem with this approach was that the sessionId was unexpectedly stored in the view context, making different parts of the code dependendent to the view logic. This new solution goal is to be more explicit, and simplify the view logic. The current session id (and type) is kept into the rumSession module, to ensure a consistency accross the RUM library. A new lifeCycle event is sent when the view is about to be renewed, but the session id is still the same.
Configuration menu - View commit details
-
Copy full SHA for 75eb286 - Browse repository at this point
Copy the full SHA 75eb286View commit details -
🚚 [RUM] rename file viewTracker to viewCollection
The view logic will be changed to emit lifeCycle events. Like other component emiting lifeCycle events, name the file as "xxCollection"
Configuration menu - View commit details
-
Copy full SHA for 601d9c9 - Browse repository at this point
Copy the full SHA 601d9c9View commit details -
[RUM] use a lifeCycle event for document unload
This change is a first step to decouple the view logic from the Batch implementation.
Configuration menu - View commit details
-
Copy full SHA for 40216df - Browse repository at this point
Copy the full SHA 40216dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a1ecf1 - Browse repository at this point
Copy the full SHA 1a1ecf1View commit details
Commits on Apr 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c09fe0a - Browse repository at this point
Copy the full SHA c09fe0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d48afc7 - Browse repository at this point
Copy the full SHA d48afc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 830877c - Browse repository at this point
Copy the full SHA 830877cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37a5ecf - Browse repository at this point
Copy the full SHA 37a5ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f51855 - Browse repository at this point
Copy the full SHA 8f51855View commit details -
◀👌 [RUM] revert the session changes and adjust tests
This reverts commit 75eb286. For now, keep the current way we handle session into RUM. We will reconsider this in a future PR.
Configuration menu - View commit details
-
Copy full SHA for 92d3a52 - Browse repository at this point
Copy the full SHA 92d3a52View commit details
Commits on Apr 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7f1f594 - Browse repository at this point
Copy the full SHA 7f1f594View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed84961 - Browse repository at this point
Copy the full SHA ed84961View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dbc153 - Browse repository at this point
Copy the full SHA 0dbc153View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64d5452 - Browse repository at this point
Copy the full SHA 64d5452View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.