pkg/trace: add support for meta_struct span proto field #10366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julio-Guerra
requested changes
Dec 29, 2021
nizox
changed the title
Julio-Guerra
approved these changes
Jan 5, 2022
|
You should also put |
gbbr
changed the title
gbbr
reviewed
Jan 5, 2022
gbbr
reviewed
Jan 6, 2022
gbbr
reviewed
Jan 6, 2022
Moutix
approved these changes
Jan 11, 2022
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
nizox
force-pushed
the
nicolas.vivet/span-meta-struct
branch
from
cdb1ac7 to
d6be19b
Compare
nizox
changed the title
raphaelgavache
approved these changes
Feb 17, 2022
dianashevchenko
requested changes
Feb 17, 2022
dianashevchenko
requested changes
Feb 17, 2022
dianashevchenko
approved these changes
Feb 18, 2022
9 tasks
|
There is not a single test in this PR which tests that a Msgpack payload containing the new field gets decoded correctly. The new decoding code has 0 coverage. 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for the
meta_structspan proto field in the trace-agent. This field is analogous tometabut allows to attach structured data serialized in msgpack to a span instead of strings.Motivation
AppSec runs inside the APM tracers and detects security events (also called triggers) thanks to AppSec rules. The security events are attached to the relevant span and are currently reported using the
_dd.appsec.jsonmeta tag as a JSON serialized string.There is currently no compatibility between the legacy
_dd.appsec.jsonmeta tag and the newappsecmeta struct tag. The tracers need to send one or the other depending on the protocol in use.Additional Notes
AppSec events are low-volume and it is estimated that 1 trace out of 100 000 have AppSec events for customers where the feature is enabled.
Possible Drawbacks / Trade-offs
Only the v0.7 protocol supports the new
meta_structfield. A flag has been introduced to indicate that an agent supports themeta_structfield.Reviewer's Checklist
Triagemilestone is set.team/..label has been applied, if known.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.need-change/operatorandneed-change/helmlabels have been applied.