Add support for meta_struct field in API v4 #7031

manuel-alvarez-alvarez · 2024-05-15T10:28:24Z

What Does This Do

This PR allows adding meta_struct data to spans, the meta_struct is lazy initialized to reduce memory consumption and uses a double locking mechanism to be initialized (same as baggage).

Motivation

The new RASP module requires this new data structure in order to be able to send binary data efficiently to the backend.

Additional Notes

The agent fully supports meta_struct from version v7.35.0 (April 2022).

Jira ticket: APPSEC-52826
Agent: DataDog/datadog-agent#10366
.NET: DataDog/dd-trace-dotnet#5287
JS: DataDog/dd-trace-js#4287

Sample result of adding a stack to the metra_struct:

manuel-alvarez-alvarez · 2024-05-15T10:29:31Z

...ce-core/src/test/groovy/datadog/trace/common/writer/ddagent/TraceMapperV04PayloadTest.groovy

All format changes in the file are due to spotless formatting the file in the pre-commit hook 😢

pr-commenter · 2024-05-15T11:14:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/add-meta-struct-support
git_commit_date	1715856651	1715858811
git_commit_sha	`d0bd085`	`124f094`
release_version	1.35.0-SNAPSHOT~d0bd085303	1.35.0-SNAPSHOT~124f09418a

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1715861391	1715861391
ci_job_id	513906172	513906172
ci_pipeline_id	34437243	34437243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077708
Total [baseline] (10.471 s) : 0, 10470516
Agent [candidate] (1.094 s) : 0, 1094328
Total [candidate] (10.421 s) : 0, 10420867
section appsec
Agent [baseline] (1.202 s) : 0, 1202159
Total [baseline] (10.532 s) : 0, 10531730
Agent [candidate] (1.198 s) : 0, 1197766
Total [candidate] (10.577 s) : 0, 10577055
section iast
Agent [baseline] (1.204 s) : 0, 1204194
Total [baseline] (10.827 s) : 0, 10826529
Agent [candidate] (1.206 s) : 0, 1206461
Total [candidate] (10.775 s) : 0, 10775291
section profiling
Agent [baseline] (1.283 s) : 0, 1282750
Total [baseline] (10.776 s) : 0, 10776404
Agent [candidate] (1.283 s) : 0, 1282987
Total [candidate] (10.721 s) : 0, 10721141

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.078 s	-
Agent	appsec	1.202 s	124.451 ms (11.5%)
Agent	iast	1.204 s	126.486 ms (11.7%)
Agent	profiling	1.283 s	205.042 ms (19.0%)
Total	tracing	10.471 s	-
Total	appsec	10.532 s	61.214 ms (0.6%)
Total	iast	10.827 s	356.013 ms (3.4%)
Total	profiling	10.776 s	305.888 ms (2.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	appsec	1.198 s	103.438 ms (9.5%)
Agent	iast	1.206 s	112.133 ms (10.2%)
Agent	profiling	1.283 s	188.659 ms (17.2%)
Total	tracing	10.421 s	-
Total	appsec	10.577 s	156.189 ms (1.5%)
Total	iast	10.775 s	354.424 ms (3.4%)
Total	profiling	10.721 s	300.274 ms (2.9%)

gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.673 ms) : 0, 674673
BytebuddyAgent [candidate] (684.699 ms) : 0, 684699
GlobalTracer [baseline] (310.572 ms) : 0, 310572
GlobalTracer [candidate] (315.481 ms) : 0, 315481
AppSec [baseline] (49.843 ms) : 0, 49843
AppSec [candidate] (50.92 ms) : 0, 50920
Remote Config [baseline] (664.249 µs) : 0, 664
Remote Config [candidate] (670.169 µs) : 0, 670
Telemetry [baseline] (7.598 ms) : 0, 7598
Telemetry [candidate] (7.684 ms) : 0, 7684
section appsec
BytebuddyAgent [baseline] (700.498 ms) : 0, 700498
BytebuddyAgent [candidate] (697.679 ms) : 0, 697679
GlobalTracer [baseline] (295.019 ms) : 0, 295019
GlobalTracer [candidate] (293.688 ms) : 0, 293688
AppSec [baseline] (153.226 ms) : 0, 153226
AppSec [candidate] (153.12 ms) : 0, 153120
IAST [baseline] (18.97 ms) : 0, 18970
IAST [candidate] (18.898 ms) : 0, 18898
Remote Config [baseline] (621.874 µs) : 0, 622
Remote Config [candidate] (622.214 µs) : 0, 622
Telemetry [baseline] (8.722 ms) : 0, 8722
Telemetry [candidate] (8.778 ms) : 0, 8778
section iast
BytebuddyAgent [baseline] (797.042 ms) : 0, 797042
BytebuddyAgent [candidate] (797.72 ms) : 0, 797720
GlobalTracer [baseline] (290.941 ms) : 0, 290941
GlobalTracer [candidate] (291.83 ms) : 0, 291830
AppSec [baseline] (51.188 ms) : 0, 51188
AppSec [candidate] (52.318 ms) : 0, 52318
IAST [baseline] (23.493 ms) : 0, 23493
IAST [candidate] (22.955 ms) : 0, 22955
Remote Config [baseline] (679.596 µs) : 0, 680
Remote Config [candidate] (596.449 µs) : 0, 596
Telemetry [baseline] (6.562 ms) : 0, 6562
Telemetry [candidate] (6.679 ms) : 0, 6679
section profiling
BytebuddyAgent [baseline] (684.417 ms) : 0, 684417
BytebuddyAgent [candidate] (683.943 ms) : 0, 683943
GlobalTracer [baseline] (385.441 ms) : 0, 385441
GlobalTracer [candidate] (386.061 ms) : 0, 386061
AppSec [baseline] (50.587 ms) : 0, 50587
AppSec [candidate] (51.306 ms) : 0, 51306
Remote Config [baseline] (733.502 µs) : 0, 734
Remote Config [candidate] (699.651 µs) : 0, 700
Telemetry [baseline] (7.567 ms) : 0, 7567
Telemetry [candidate] (7.488 ms) : 0, 7488
ProfilingAgent [baseline] (97.102 ms) : 0, 97102
ProfilingAgent [candidate] (96.71 ms) : 0, 96710
Profiling [baseline] (97.127 ms) : 0, 97127
Profiling [candidate] (96.734 ms) : 0, 96734

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087580
Total [baseline] (8.596 s) : 0, 8596079
Agent [candidate] (1.079 s) : 0, 1079197
Total [candidate] (8.579 s) : 0, 8579136
section iast
Agent [baseline] (1.208 s) : 0, 1207635
Total [baseline] (9.047 s) : 0, 9047044
Agent [candidate] (1.215 s) : 0, 1215372
Total [candidate] (9.062 s) : 0, 9062026
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.208 s) : 0, 1208415
Total [baseline] (9.05 s) : 0, 9050232
Agent [candidate] (1.215 s) : 0, 1214897
Total [candidate] (9.06 s) : 0, 9059501
section iast_TELEMETRY_OFF
Agent [baseline] (1.21 s) : 0, 1209978
Total [baseline] (9.02 s) : 0, 9020166
Agent [candidate] (1.206 s) : 0, 1205747
Total [candidate] (9.028 s) : 0, 9027751

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.208 s	120.055 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.208 s	120.835 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.21 s	122.398 ms (11.3%)
Total	tracing	8.596 s	-
Total	iast	9.047 s	450.965 ms (5.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.05 s	454.153 ms (5.3%)
Total	iast_TELEMETRY_OFF	9.02 s	424.087 ms (4.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	iast	1.215 s	136.175 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.215 s	135.7 ms (12.6%)
Agent	iast_TELEMETRY_OFF	1.206 s	126.551 ms (11.7%)
Total	tracing	8.579 s	-
Total	iast	9.062 s	482.89 ms (5.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.06 s	480.365 ms (5.6%)
Total	iast_TELEMETRY_OFF	9.028 s	448.615 ms (5.2%)

gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.931 ms) : 0, 680931
BytebuddyAgent [candidate] (675.282 ms) : 0, 675282
GlobalTracer [baseline] (313.599 ms) : 0, 313599
GlobalTracer [candidate] (311.344 ms) : 0, 311344
AppSec [baseline] (50.03 ms) : 0, 50030
AppSec [candidate] (49.875 ms) : 0, 49875
Remote Config [baseline] (663.145 µs) : 0, 663
Remote Config [candidate] (655.733 µs) : 0, 656
Telemetry [baseline] (7.669 ms) : 0, 7669
Telemetry [candidate] (7.647 ms) : 0, 7647
section iast
BytebuddyAgent [baseline] (799.864 ms) : 0, 799864
BytebuddyAgent [candidate] (804.741 ms) : 0, 804741
GlobalTracer [baseline] (291.675 ms) : 0, 291675
GlobalTracer [candidate] (293.537 ms) : 0, 293537
AppSec [baseline] (50.99 ms) : 0, 50990
AppSec [candidate] (51.554 ms) : 0, 51554
IAST [baseline] (23.491 ms) : 0, 23491
IAST [candidate] (23.395 ms) : 0, 23395
Remote Config [baseline] (584.918 µs) : 0, 585
Remote Config [candidate] (604.618 µs) : 0, 605
Telemetry [baseline] (6.591 ms) : 0, 6591
Telemetry [candidate] (6.784 ms) : 0, 6784
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.17 ms) : 0, 798170
BytebuddyAgent [candidate] (804.425 ms) : 0, 804425
GlobalTracer [baseline] (293.416 ms) : 0, 293416
GlobalTracer [candidate] (293.769 ms) : 0, 293769
AppSec [baseline] (51.137 ms) : 0, 51137
AppSec [candidate] (50.633 ms) : 0, 50633
IAST [baseline] (24.009 ms) : 0, 24009
IAST [candidate] (24.004 ms) : 0, 24004
Remote Config [baseline] (604.203 µs) : 0, 604
Remote Config [candidate] (599.778 µs) : 0, 600
Telemetry [baseline] (6.687 ms) : 0, 6687
Telemetry [candidate] (6.729 ms) : 0, 6729
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.248 ms) : 0, 800248
BytebuddyAgent [candidate] (797.319 ms) : 0, 797319
GlobalTracer [baseline] (293.362 ms) : 0, 293362
GlobalTracer [candidate] (292.851 ms) : 0, 292851
AppSec [baseline] (51.554 ms) : 0, 51554
AppSec [candidate] (51.134 ms) : 0, 51134
IAST [baseline] (22.208 ms) : 0, 22208
IAST [candidate] (22.75 ms) : 0, 22750
Remote Config [baseline] (1.426 ms) : 0, 1426
Remote Config [candidate] (596.718 µs) : 0, 597
Telemetry [baseline] (6.634 ms) : 0, 6634
Telemetry [candidate] (6.587 ms) : 0, 6587

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-05-16T11:40:27	2024-05-16T11:47:17
git_branch	master	malvarez/add-meta-struct-support
git_commit_date	1715856651	1715858811
git_commit_sha	`d0bd085`	`124f094`
release_version	1.35.0-SNAPSHOT~d0bd085303	1.35.0-SNAPSHOT~124f09418a
start_time	2024-05-16T11:40:14	2024-05-16T11:47:04

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1715860383	1715860383
ci_job_id	513906173	513906173
ci_pipeline_id	34437243	34437243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.339 µs) : 357, 398
.   : milestone, 377,
iast (482.022 µs) : 461, 503
.   : milestone, 482,
iast_FULL (550.8 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (510.465 µs) : 489, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (484.941 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (460.651 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (480.018 µs) : 458, 502
.   : milestone, 480,
tracing (441.044 µs) : 421, 461
.   : milestone, 441,
section candidate
no_agent (371.018 µs) : 351, 391
.   : milestone, 371,
iast (487.691 µs) : 466, 509
.   : milestone, 488,
iast_FULL (557.128 µs) : 536, 578
.   : milestone, 557,
iast_GLOBAL (507.48 µs) : 486, 529
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (484.616 µs) : 464, 506
.   : milestone, 485,
iast_INACTIVE (459.203 µs) : 438, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (481.955 µs) : 460, 503
.   : milestone, 482,
tracing (444.31 µs) : 423, 465
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.339 µs [356.543 µs, 398.136 µs]	-
iast	482.022 µs [460.898 µs, 503.145 µs]	104.682 µs (27.7%)
iast_FULL	550.8 µs [529.525 µs, 572.075 µs]	173.46 µs (46.0%)
iast_GLOBAL	510.465 µs [488.798 µs, 532.132 µs]	133.126 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED	484.941 µs [463.85 µs, 506.032 µs]	107.601 µs (28.5%)
iast_INACTIVE	460.651 µs [439.117 µs, 482.185 µs]	83.311 µs (22.1%)
iast_TELEMETRY_OFF	480.018 µs [457.868 µs, 502.167 µs]	102.679 µs (27.2%)
tracing	441.044 µs [420.833 µs, 461.254 µs]	63.704 µs (16.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.018 µs [351.265 µs, 390.771 µs]	-
iast	487.691 µs [465.898 µs, 509.485 µs]	116.673 µs (31.4%)
iast_FULL	557.128 µs [536.021 µs, 578.235 µs]	186.11 µs (50.2%)
iast_GLOBAL	507.48 µs [485.634 µs, 529.326 µs]	136.462 µs (36.8%)
iast_HARDCODED_SECRET_DISABLED	484.616 µs [463.542 µs, 505.689 µs]	113.597 µs (30.6%)
iast_INACTIVE	459.203 µs [437.763 µs, 480.644 µs]	88.185 µs (23.8%)
iast_TELEMETRY_OFF	481.955 µs [460.468 µs, 503.442 µs]	110.937 µs (29.9%)
tracing	444.31 µs [423.132 µs, 465.487 µs]	73.292 µs (19.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.326 ms) : 1307, 1346
.   : milestone, 1326,
appsec (1.732 ms) : 1708, 1756
.   : milestone, 1732,
appsec_no_iast (1.696 ms) : 1671, 1721
.   : milestone, 1696,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.483 ms) : 1458, 1508
.   : milestone, 1483,
tracing (1.465 ms) : 1440, 1489
.   : milestone, 1465,
section candidate
no_agent (1.333 ms) : 1313, 1353
.   : milestone, 1333,
appsec (1.723 ms) : 1699, 1746
.   : milestone, 1723,
appsec_no_iast (1.715 ms) : 1691, 1740
.   : milestone, 1715,
iast (1.49 ms) : 1467, 1513
.   : milestone, 1490,
profiling (1.498 ms) : 1473, 1524
.   : milestone, 1498,
tracing (1.468 ms) : 1443, 1493
.   : milestone, 1468,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.326 ms [1.307 ms, 1.346 ms]	-
appsec	1.732 ms [1.708 ms, 1.756 ms]	405.503 µs (30.6%)
appsec_no_iast	1.696 ms [1.671 ms, 1.721 ms]	370.03 µs (27.9%)
iast	1.488 ms [1.465 ms, 1.511 ms]	161.616 µs (12.2%)
profiling	1.483 ms [1.458 ms, 1.508 ms]	156.476 µs (11.8%)
tracing	1.465 ms [1.44 ms, 1.489 ms]	138.48 µs (10.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.333 ms [1.313 ms, 1.353 ms]	-
appsec	1.723 ms [1.699 ms, 1.746 ms]	389.583 µs (29.2%)
appsec_no_iast	1.715 ms [1.691 ms, 1.74 ms]	382.304 µs (28.7%)
iast	1.49 ms [1.467 ms, 1.513 ms]	156.762 µs (11.8%)
profiling	1.498 ms [1.473 ms, 1.524 ms]	165.447 µs (12.4%)
tracing	1.468 ms [1.443 ms, 1.493 ms]	134.849 µs (10.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/add-meta-struct-support
git_commit_date	1715856651	1715858811
git_commit_sha	`d0bd085`	`124f094`
release_version	1.35.0-SNAPSHOT~d0bd085303	1.35.0-SNAPSHOT~124f09418a

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1715860993	1715860993
ci_job_id	513906175	513906175
ci_pipeline_id	34437243	34437243
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.199 ms) : 2165, 2233
.   : milestone, 2199,
iast (1.958 ms) : 1916, 1999
.   : milestone, 1958,
iast_GLOBAL (1.976 ms) : 1936, 2017
.   : milestone, 1976,
profiling (1.834 ms) : 1802, 1866
.   : milestone, 1834,
tracing (1.817 ms) : 1785, 1849
.   : milestone, 1817,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.189 ms) : 2155, 2223
.   : milestone, 2189,
iast (1.95 ms) : 1909, 1990
.   : milestone, 1950,
iast_GLOBAL (1.983 ms) : 1942, 2023
.   : milestone, 1983,
profiling (1.834 ms) : 1802, 1867
.   : milestone, 1834,
tracing (1.833 ms) : 1801, 1865
.   : milestone, 1833,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.46 ms [1.448 ms, 1.471 ms]	-
appsec	2.199 ms [2.165 ms, 2.233 ms]	739.469 µs (50.7%)
iast	1.958 ms [1.916 ms, 1.999 ms]	498.102 µs (34.1%)
iast_GLOBAL	1.976 ms [1.936 ms, 2.017 ms]	516.73 µs (35.4%)
profiling	1.834 ms [1.802 ms, 1.866 ms]	374.531 µs (25.7%)
tracing	1.817 ms [1.785 ms, 1.849 ms]	357.134 µs (24.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.449 ms, 1.472 ms]	-
appsec	2.189 ms [2.155 ms, 2.223 ms]	728.486 µs (49.9%)
iast	1.95 ms [1.909 ms, 1.99 ms]	489.091 µs (33.5%)
iast_GLOBAL	1.983 ms [1.942 ms, 2.023 ms]	522.192 µs (35.8%)
profiling	1.834 ms [1.802 ms, 1.867 ms]	373.744 µs (25.6%)
tracing	1.833 ms [1.801 ms, 1.865 ms]	372.601 µs (25.5%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~124f09418a, baseline=1.35.0-SNAPSHOT~d0bd085303
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
appsec (14.979 s) : 14979000, 14979000
.   : milestone, 14979000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (17.971 s) : 17971000, 17971000
.   : milestone, 17971000,
profiling (14.873 s) : 14873000, 14873000
.   : milestone, 14873000,
tracing (14.777 s) : 14777000, 14777000
.   : milestone, 14777000,
section candidate
no_agent (15.335 s) : 15335000, 15335000
.   : milestone, 15335000,
appsec (15.165 s) : 15165000, 15165000
.   : milestone, 15165000,
iast (18.642 s) : 18642000, 18642000
.   : milestone, 18642000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
.   : milestone, 17981000,
profiling (15.856 s) : 15856000, 15856000
.   : milestone, 15856000,
tracing (14.871 s) : 14871000, 14871000
.   : milestone, 14871000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.03 s [15.03 s, 15.03 s]	-
appsec	14.979 s [14.979 s, 14.979 s]	-51.0 ms (-0.3%)
iast	18.852 s [18.852 s, 18.852 s]	3.822 s (25.4%)
iast_GLOBAL	17.971 s [17.971 s, 17.971 s]	2.941 s (19.6%)
profiling	14.873 s [14.873 s, 14.873 s]	-157.0 ms (-1.0%)
tracing	14.777 s [14.777 s, 14.777 s]	-253.0 ms (-1.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.335 s [15.335 s, 15.335 s]	-
appsec	15.165 s [15.165 s, 15.165 s]	-170.0 ms (-1.1%)
iast	18.642 s [18.642 s, 18.642 s]	3.307 s (21.6%)
iast_GLOBAL	17.981 s [17.981 s, 17.981 s]	2.646 s (17.3%)
profiling	15.856 s [15.856 s, 15.856 s]	521.0 ms (3.4%)
tracing	14.871 s [14.871 s, 14.871 s]	-464.0 ms (-3.0%)

smola

Looks good assuming it works with a real agent.

dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_4.java

PerfectSlayer

Sorry for the delay!
Two minor comments about API documentation and we should be good to go

dd-trace-core/src/main/java/datadog/trace/core/CoreSpan.java

dd-trace-api/src/main/java/datadog/trace/api/internal/TraceSegment.java

manuel-alvarez-alvarez · 2024-05-23T14:34:57Z

Sorry for the delay! Two minor comments about API documentation and we should be good to go

No worries, thanks for the review!

manuel-alvarez-alvarez added comp: core Tracer core comp: asm waf Application Security Management (WAF) labels May 15, 2024

manuel-alvarez-alvarez commented May 15, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch 4 times, most recently from 82f6efe to 00a70bf Compare May 16, 2024 07:50

smola approved these changes May 16, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/common/writer/ddagent/TraceMapperV0_4.java Outdated Show resolved Hide resolved

manuel-alvarez-alvarez marked this pull request as ready for review May 16, 2024 10:04

manuel-alvarez-alvarez requested a review from a team as a code owner May 16, 2024 10:04

manuel-alvarez-alvarez requested review from PerfectSlayer and am312 May 16, 2024 10:04

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch 3 times, most recently from 00188e2 to 124f094 Compare May 16, 2024 11:27

manuel-alvarez-alvarez requested a review from ValentinZakharov May 17, 2024 09:54

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch 2 times, most recently from 2b40f78 to af67f12 Compare May 21, 2024 07:32

PerfectSlayer reviewed May 23, 2024

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/CoreSpan.java Outdated Show resolved Hide resolved

dd-trace-api/src/main/java/datadog/trace/api/internal/TraceSegment.java Outdated Show resolved Hide resolved

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch from af67f12 to 5c283c9 Compare May 23, 2024 14:33

manuel-alvarez-alvarez requested a review from PerfectSlayer May 23, 2024 14:35

PerfectSlayer approved these changes May 24, 2024

View reviewed changes

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch from 5c283c9 to 4bc5b28 Compare May 24, 2024 08:06

ValentinZakharov approved these changes May 24, 2024

View reviewed changes

manuel-alvarez-alvarez added 4 commits May 27, 2024 09:37

Add support for meta_struct field in API v4

78528f2

Switch to binaries in the meta_struct field

29fb24e

Move to a concurrent map for the meta struct field

d56ad25

Refactors javadoc comments for the meta_struct as per the PR

4124465

manuel-alvarez-alvarez force-pushed the malvarez/add-meta-struct-support branch from 4bc5b28 to 4124465 Compare May 27, 2024 07:37

manuel-alvarez-alvarez merged commit 61ada2c into master May 27, 2024
76 of 79 checks passed

manuel-alvarez-alvarez deleted the malvarez/add-meta-struct-support branch May 27, 2024 08:17

github-actions bot added this to the 1.35.0 milestone May 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for meta_struct field in API v4 #7031

Add support for meta_struct field in API v4 #7031

manuel-alvarez-alvarez commented May 15, 2024 •

edited

Loading

manuel-alvarez-alvarez May 15, 2024 •

edited

Loading

pr-commenter bot commented May 15, 2024 •

edited

Loading

smola left a comment

PerfectSlayer left a comment

manuel-alvarez-alvarez commented May 23, 2024

Add support for meta_struct field in API v4 #7031

Add support for meta_struct field in API v4 #7031

Conversation

manuel-alvarez-alvarez commented May 15, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

manuel-alvarez-alvarez May 15, 2024 • edited Loading

Choose a reason for hiding this comment

pr-commenter bot commented May 15, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

smola left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

manuel-alvarez-alvarez commented May 23, 2024

manuel-alvarez-alvarez commented May 15, 2024 •

edited

Loading

manuel-alvarez-alvarez May 15, 2024 •

edited

Loading

pr-commenter bot commented May 15, 2024 •

edited

Loading