Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meta_struct in v0.4 #4287

Merged
merged 9 commits into from
May 16, 2024
Merged

Support meta_struct in v0.4 #4287

merged 9 commits into from
May 16, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented May 8, 2024

What does this PR do?

Add support for meta_struct property in the spans for v0.4 agent api.
meta_struct is expected to be an object with inner objects or arrays, not only key: number|string as we have in the current tags.

Motivation

It will be used in the near future to send stack traces associated with detected threats.

Checklist

  • Unit tests.

Additional Notes

APPSEC-52970

Copy link

github-actions bot commented May 8, 2024

Overall package size

Self size: 6.47 MB
Deduped: 59.17 MB
No deduping: 59.45 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@uurien uurien force-pushed the ugaitz/support-meta_struct branch from c34aa95 to 4dd41c8 Compare May 8, 2024 10:31
@uurien uurien force-pushed the ugaitz/support-meta_struct branch from 8ff0b31 to 8ece6f1 Compare May 8, 2024 10:41
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2024

Benchmarks

Benchmark execution time: 2024-05-13 10:27:19

Comparing candidate commit 33caa74 in PR branch ugaitz/support-meta_struct with baseline commit f4adddc in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@uurien uurien added the asm-waf label May 8, 2024
@uurien uurien marked this pull request as ready for review May 9, 2024 14:12
@uurien uurien requested a review from a team as a code owner May 9, 2024 14:12
@simon-id
Copy link
Member

FTR, why not v0.5 ?

@uurien
Copy link
Collaborator Author

uurien commented May 10, 2024

FTR, why not v0.5 ?

The v0.5 API does not support it (at least for now)

Qard
Qard previously approved these changes May 13, 2024
simon-id
simon-id previously approved these changes May 13, 2024
@uurien uurien dismissed stale reviews from simon-id and Qard via d702a24 May 13, 2024 10:02
@uurien uurien merged commit 962bccc into master May 16, 2024
108 of 111 checks passed
@uurien uurien deleted the ugaitz/support-meta_struct branch May 16, 2024 14:53
khanayan123 pushed a commit that referenced this pull request May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 16, 2024
This was referenced May 16, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
khanayan123 pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants