Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename daemonset.updated metrics source #11369

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

clamoriniere
Copy link
Contributor

What does this PR do?

The kube-state-metrics metric kube_daemonset_updated_number_scheduled was renamed to kube_daemonset_status_updated_number_scheduled in a late v2.0.0 alpha version (see: kubernetes/kube-state-metrics#1181)

our check was still using the old name so the daemonset.updated metrics was not generated.

Motivation

Fix bug reported on the kubernetes_state.daemonset.updated metrics.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

The kube-state-metrics metric `kube_daemonset_updated_number_scheduled` was renamed to `kube_daemonset_status_updated_number_scheduled` in a late v2.0.0 alpha version (see: kubernetes/kube-state-metrics#1181)

our check was still using the old name so the `daemonset.updated` metrics was not generated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants