Update DaemonSet updated_number_scheduled metric name to be consistent #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
needs-rebase
vishnukarthikl
force-pushed
the
daemonset-update
branch
from
e0f8a63
to
8031a70
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm Thanks @vishnukarthikl :) |
k8s-ci-robot
added
the
lgtm
tariq1890
approved these changes
Jul 25, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tariq1890, vishnukarthikl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
clamoriniere
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 18, 2022
The kube-state-metrics metric `kube_daemonset_updated_number_scheduled` was renamed to `kube_daemonset_status_updated_number_scheduled` in a late v2.0.0 alpha version (see: kubernetes/kube-state-metrics#1181) our check was still using the old name so the `daemonset.updated` metrics was not generated.
9 tasks
clamoriniere
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 21, 2022
The kube-state-metrics metric `kube_daemonset_updated_number_scheduled` was renamed to `kube_daemonset_status_updated_number_scheduled` in a late v2.0.0 alpha version (see: kubernetes/kube-state-metrics#1181) our check was still using the old name so the `daemonset.updated` metrics was not generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
rename metric
kube_daemonset_updated_number_scheduledtokube_daemonset_status_updated_number_scheduledso that it is consistent with the field path. This was discussed here