Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alerts: update daemonset updated_number_scheduled metric name #732

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Jan 12, 2022

This is to support kube-state-metrics v2.0.0+.

kubernetes/kube-state-metrics#1181 renamed metric kube_daemonset_updated_number_scheduled to kube_daemonset_status_updated_number_scheduled.

Copy link
Contributor

@arajkumar arajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, Looks good to me.

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! However, before we can merge it, tests need to be also amended to use a new metric name. Without this CI will constantly fail.

The following lines need to be amended:

  • - series: 'kube_daemonset_updated_number_scheduled{job="kube-state-metrics",namespace="monitoring",daemonset="node-exporter"}'
  • - series: 'kube_daemonset_updated_number_scheduled{job="kube-state-metrics",namespace="monitoring",daemonset="node-exporter"}'
  • - series: 'kube_daemonset_updated_number_scheduled{job="kube-state-metrics",namespace="monitoring",daemonset="node-exporter"}'

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you 💯

@paulfantom paulfantom merged commit c76b937 into kubernetes-monitoring:master Jan 13, 2022
@junotx junotx deleted the ds-metrics branch January 17, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants