-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreateContainerError
and InvalidImageName
to waiting reasons
#13139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Hi, this PR comes out of a Datadog support ticket that I filed - very grateful to @keisku for diagnosing the issue and taking this straight here. I can see this has been added to the 7.40 milestone. As this is for an ongoing problem we are facing (we need to detect & alert on containers in CreateContainerError state), is there any chance to pull this forward to 7.39? Let me know if there is anything I can do to help. Thanks. |
What does this PR do?
Add
CreateContainerError
andInvalidImageName
to waiting reasons.Motivation
kubernetes/kube-state-metrics#763 is the similar work.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.