Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateContainerError and InvalidImageName to waiting reasons #13139

Merged
merged 8 commits into from
Aug 18, 2022

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Aug 17, 2022

What does this PR do?

Add CreateContainerError and InvalidImageName to waiting reasons.

Motivation

kubernetes/kube-state-metrics#763 is the similar work.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@keisku keisku requested a review from a team as a code owner August 17, 2022 11:42
@keisku keisku modified the milestones: 7.39.0, 7.40.0 Aug 17, 2022
@keisku keisku requested a review from a team as a code owner August 17, 2022 11:47
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@keisku keisku merged commit 8f7c5f7 into main Aug 18, 2022
@keisku keisku deleted the keisku/add-waiting-reasons branch August 18, 2022 23:12
@lerlacher-haylix
Copy link

Hi,

this PR comes out of a Datadog support ticket that I filed - very grateful to @keisku for diagnosing the issue and taking this straight here.

I can see this has been added to the 7.40 milestone. As this is for an ongoing problem we are facing (we need to detect & alert on containers in CreateContainerError state), is there any chance to pull this forward to 7.39?

Let me know if there is anything I can do to help.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants