Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateContainerError and InvalidImageName waiting reasons #763

Merged
merged 1 commit into from
May 18, 2019
Merged

Add CreateContainerError and InvalidImageName waiting reasons #763

merged 1 commit into from
May 18, 2019

Conversation

jdewald
Copy link
Contributor

@jdewald jdewald commented May 17, 2019

What this PR does / why we need it:

Adds 'CreateContainerError' and 'InvalidImageName' to the available container waiting reasons, which we need visibility into in our production environment

@k8s-ci-robot
Copy link
Contributor

Welcome @jdewald!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2019
tariq1890
tariq1890 reviewed May 17, 2019
View reviewed changes
internal/collector/pod.go Outdated
@@ -34,7 +34,7 @@ const nodeUnreachablePodReason = "NodeLost"

var (
descPodLabelsDefaultLabels = []string{"namespace", "pod"}
containerWaitingReasons = []string{"ContainerCreating", "CrashLoopBackOff", "CreateContainerConfigError", "ErrImagePull", "ImagePullBackOff"}
containerWaitingReasons = []string{"ContainerCreating", "CrashLoopBackOff", "CreateContainerConfigError", "ErrImagePull", "ImagePullBackOff","CreateContainerError","InvalidImageName"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there needs to be spaces after the commas.

Suggested change
containerWaitingReasons = []string{"ContainerCreating", "CrashLoopBackOff", "CreateContainerConfigError", "ErrImagePull", "ImagePullBackOff","CreateContainerError","InvalidImageName"}
containerWaitingReasons = []string{"ContainerCreating", "CrashLoopBackOff", "CreateContainerConfigError", "ErrImagePull", "ImagePullBackOff", "CreateContainerError", "InvalidImageName"}

@tariq1890
Copy link
Contributor

@jdewald Welcome and Thank you very much for contributing :). I think the failing unit tests need to be taken care of.

PR looks good otherwise.

@tariq1890
Copy link
Contributor

Also, please don't forget to squash your commit history after making the required changes.

@jdewald
Copy link
Contributor Author

jdewald commented May 17, 2019

@tariq1890 Thanks! I totally should have run the linting before I committed!

@jdewald
Copy link
Contributor Author

jdewald commented May 17, 2019

Applying squash now

@jdewald
Copy link
Contributor Author

jdewald commented May 17, 2019

It looks like test is failing, though it passed locally. Seeing if I can reproduce.

tariq1890
tariq1890 approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@brancz
Copy link
Member

brancz commented May 18, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, jdewald, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 43cce2d into kubernetes:master May 18, 2019
@jdewald jdewald deleted the add-missing-states branch May 18, 2019 03:25
This was referenced Aug 17, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@andyxning andyxning Awaiting requested review from andyxning

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@tariq1890 tariq1890

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdewald @k8s-ci-robot @tariq1890 @brancz