Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateContainerError and InvalidImageName to waiting reasons #12758

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Add CreateContainerError and InvalidImageName to waiting reasons #12758

merged 2 commits into from
Aug 25, 2022

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Aug 17, 2022

What does this PR do?

Add CreateContainerError and InvalidImageName to waiting reasons.

Motivation

kubernetes/kube-state-metrics#763 is the similar work.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@keisku keisku requested review from a team as code owners August 17, 2022 12:19
@codecov
Copy link

codecov bot commented Aug 17, 2022 •
edited

Codecov Report

Merging #12758 (5dbc333) into master (3780660) will not change coverage.
The diff coverage is 100.00%.

Flag Coverage Δ
kubelet 90.85% <ø> (ø)
kubernetes_state 89.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

FlorentClarret
FlorentClarret approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry for the delay

@FlorentClarret FlorentClarret merged commit 2f69195 into master Aug 25, 2022
@FlorentClarret FlorentClarret deleted the keisku/add-waiting-reasons branch August 25, 2022 08:04
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
@keisku @steveny91
Add CreateContainerError and InvalidImageName to waiting reasons (#…
f7b7913 
…12758)

* add waiting reasons

* format
@malmon-circle malmon-circle mentioned this pull request Nov 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@ahmed-mez ahmed-mez ahmed-mez approved these changes

Assignees
No one assigned
Labels
integration/kubelet integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keisku @FlorentClarret @ahmed-mez