-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCA][Flare] Adds Helm user values, cluster Agent manifest, node Agent manifest v2 #16313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase + addresses comments
…ds (eg CloudFoundry)
hush-hush
approved these changes
Mar 29, 2023
clamoriniere
approved these changes
Mar 29, 2023
hestonhoffman
approved these changes
Mar 29, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important note
manifests_nocompile
implementation for//go:build !kubeapiserver
builds (eg CloudFoundry)What does this PR do?
Motivation
Additional Notes
secrets
, so the Cluster Agent needs the associated RBAC to access secrets in its namespaces. Even if the storage driver isconfigmap
, by default, the DCA does not have necessarily the RBAC unless the Helm check is enabled, so it requires a Helm chart change to add RBAC for it and disable it if not desired (on top of the required env vars)Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
3 scenarios to test :
HELM_DRIVER=secret
)HELM_DRIVER=configmap
)clusterAgent.rbac.flareAdditionalPermissions
set totrue
(default)agent flare
command.agent-daemonset.yaml
cluster-agent-deployment.yaml
helm-values.yaml
4. Ensure potential sensitive values are redacted, such as API keys
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.