-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCA][Flare] Adds DatadogAgent
user values
#30372
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 01da4b5 Optimization Goals: ❌ Significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
❌ | basic_py_check | % cpu utilization | +5.92 | [+1.86, +9.99] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.77 | [+0.71, +0.82] | 1 | Logs |
➖ | idle_all_features | memory utilization | +0.67 | [+0.56, +0.77] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | +0.48 | [+0.34, +0.62] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.39 | [+0.34, +0.44] | 1 | Logs bounds checks dashboard |
➖ | idle | memory utilization | +0.28 | [+0.23, +0.33] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.19 | [-0.54, +0.92] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.45, +0.53] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.00 | [-0.25, +0.25] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.22, +0.22] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.09, +0.08] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.01 | [-0.34, +0.32] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.05 | [-0.22, +0.13] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.46 | [-0.56, -0.36] | 1 | Logs bounds checks dashboard |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.52 | [-4.99, +1.94] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48321804 --os-family=ubuntu Note: This applies to commit 1411c89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with very minor grammar suggestion, thanks!
releasenotes/notes/add-datadogagent-manifest-flare-d842872ee18fe0c1.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to review the code added in manifest as it's really out of my knowledge base, but LGTM
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
DatadogAgent
user values by retrieving it from the API serverMotivation
Same motivation, help with troubleshooting:
Describe how to test/QA your changes
Using a
kind
cluster with the Operator built from below PR:DatadogAgent
manifestdatadog-agent-cr.yaml
: theDatadogAgent
resourceagent-daemonset.yaml
: the node Agent daemonset manifestcluster-agent-deployment.yaml
: the DCA deployment manifestPossible Drawbacks / Trade-offs
N/A
Additional Notes