Use go version 1.21.0 in go.mod directives #24688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liustanley
changed the title
paulcacheux
requested changes
Apr 15, 2024
FlorentClarret
approved these changes
Apr 16, 2024
mx-psi
approved these changes
Apr 16, 2024
knusbaum
approved these changes
Apr 16, 2024
rayz
approved these changes
Apr 16, 2024
robertjli
approved these changes
Apr 16, 2024
pducolin
approved these changes
Apr 16, 2024
pgimalac
approved these changes
Apr 16, 2024
jszwedko
approved these changes
Apr 16, 2024
zoedt
approved these changes
Apr 16, 2024
gh123man
approved these changes
Apr 16, 2024
clarkb7
approved these changes
Apr 16, 2024
raphaelgavache
approved these changes
Apr 17, 2024
BaptisteFoy
approved these changes
Apr 18, 2024
davidor
approved these changes
Apr 18, 2024
mfpierre
approved these changes
Apr 18, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 49m) Use |
CelianR
pushed a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: raphaelgavache <raphael.gavache@datadoghq.com>
alexgallotta
pushed a commit
that referenced
this pull request
May 9, 2024
Co-authored-by: raphaelgavache <raphael.gavache@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the go version from 1.21.9 to 1.21.0 in all go.mod directives.
Motivation
The go version upgrade to 1.21.9 was a breaking change for our components in opentelemetry-collector-contrib which still uses go 1.21 in their go.mod files. When we try to upgrade the datadog-agent dependencies in the collector, this also changes the collector go.mod version to 1.21.9 (example).
opentelemetry-collector-contrib uses a majority of the datadog-agent modules, so we decided to use
go 1.21.0for all of the datadog-agent modules in order to avoid future conflicts.See slack thread for more context: https://dd.slack.com/archives/C03ER8VH3NY/p1713189823890899
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes