Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go mod upgrade #24721

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix go mod upgrade #24721

merged 1 commit into from
Apr 17, 2024

Conversation

raphaelgavache
Copy link
Contributor

We recently replaced updater -> installer, fixing this go mod upgrade pr #24688 (review)

@pr-commenter
Copy link

pr-commenter bot commented Apr 16, 2024

Regression Detector

Regression Detector Results

Run ID: 493c094a-a3a3-49f0-890d-009e6f52b844
Baseline: 9d36fd1
Comparison: 7476f09

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.34 [-6.16, +5.48]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +0.69 [+0.61, +0.77]
process_agent_standard_check_with_stats memory utilization +0.18 [+0.14, +0.23]
uds_dogstatsd_to_api_cpu % cpu utilization +0.18 [-2.75, +3.11]
file_tree memory utilization +0.18 [+0.06, +0.30]
idle memory utilization +0.12 [+0.07, +0.16]
otel_to_otel_logs ingress throughput +0.05 [-0.38, +0.49]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
trace_agent_json ingress throughput +0.01 [-0.01, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.20]
process_agent_real_time_mode memory utilization -0.15 [-0.20, -0.11]
process_agent_standard_check memory utilization -0.18 [-0.24, -0.13]
file_to_blackhole % cpu utilization -0.34 [-6.16, +5.48]
basic_py_check % cpu utilization -0.53 [-2.96, +1.90]
pycheck_1000_100byte_tags % cpu utilization -1.23 [-6.11, +3.65]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@liustanley liustanley merged commit 67e4e3b into stanley.liu/go-1.21 Apr 17, 2024
310 of 314 checks passed
@liustanley liustanley deleted the raphael/fix_helper branch April 17, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants