Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.57.x] Fix X-Datadog-Container-Tags header containing line breaks #28698

Closed
wants to merge 1 commit into from

Conversation

ichinaski
Copy link
Contributor

What does this PR do?

This was already merged in #28662

HTTP header values cannot contain line breaks. This PR ensures that if Container Tags contain line breaks, the value is sanitized to replace those line breaks with underscores. It would otherwise result in an invalid header/request.

Motivation

https://datadoghq.atlassian.net/browse/APMS-13035

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@ichinaski ichinaski added changelog/no-changelog team/agent-apm trace-agent qa/done Skip QA week as QA was done before merge and regressions are covered by tests backport/7.57.x labels Aug 23, 2024
@ichinaski ichinaski requested a review from a team as a code owner August 23, 2024 10:41
@ichinaski ichinaski added this to the 7.57.0 milestone Aug 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=42668751 --os-family=ubuntu

Note: This applies to commit 9fedc09

@ichinaski
Copy link
Contributor Author

Closing this in favor of #28699

@ichinaski ichinaski closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.57.x changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant