[Backport 7.57.x] [APM] Normalize X-Datadog-Container-Tags header #28699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![agent-platform-auto-pr[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
(cherry picked from commit 296ae23)
agent-platform-auto-pr
bot
added
team/agent-apm
ichinaski
approved these changes
Aug 23, 2024
FlorentClarret
approved these changes
Aug 23, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=42669564 --os-family=ubuntuNote: This applies to commit cbd4830 |
This was referenced Sep 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 296ae23 from #28662.
HTTP header values cannot contain line breaks. This PR ensures that if Container Tags contain line breaks, the value is sanitized to replace those line breaks with underscores. It would otherwise result in an invalid header/request.
What does this PR do?
This is a fix for https://datadoghq.atlassian.net/browse/APMS-13035
HTTP header values cannot contain line breaks. This PR ensures that if Container Tags contain line breaks, the value is sanitized to replace those line breaks with underscores. It would otherwise result in an invalid header/request.
Motivation
https://datadoghq.atlassian.net/browse/APMS-13035
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes