Migrate to Net::HTTP adapter from Core module of ddtrace gem #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
force-pushed
the
anmarchenko/agentless_part2
branch
from
ed837c4
to
a80ede5
Compare
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 99.19% 99.09% -0.10%
==========================================
Files 95 95
Lines 3459 3299 -160
Branches 130 129 -1
==========================================
- Hits 3431 3269 -162
- Misses 28 30 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anmarchenko
changed the title
anmarchenko
changed the title
anmarchenko
changed the title
ekump
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Closes #47
What does this PR do?
Updates ddtrace version to 1.15 and reuses existing Net::HTTP adapter from the core library instead of our own.
Motivation
Reduce code duplication and reuse existing modules from Datadog::Core
How to test the change?
Unit tests