-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSPM] Disabling host benchmarks should be propagated to the agent #1276
Conversation
6f00713
to
3477a3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
- Coverage 54.89% 54.75% -0.15%
==========================================
Files 241 241
Lines 27901 28021 +120
==========================================
+ Hits 15317 15343 +26
- Misses 11713 11808 +95
+ Partials 871 870 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fd998ab
to
784953e
Compare
784953e
to
ba07ae9
Compare
1c8dbcd
to
c57839a
Compare
…1276) * [CSPM] Disabling host benchmarks should be propagated to the agent * enabling host benchmarks by default * add tests for CSPM and CWS default values * update generated files
What does this PR do?
Host benchmarks configuration needs always to be propagated to the agent so that deactivation takes effect.
Motivation
Same as DataDog/helm-charts#1446.
Minimum Agent Versions
No minimum.
This fix however is only targetting agents >= 7.53.0 which enabled host benchmarks by default.
Describe your test plan
When deactivating CSPM Host Benchmarks, the agent should effectively deactivate them. Relevant tests:
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label