Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that disabling CSPM host benchmarks is propagated to the agent #1446

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

paulcacheux
Copy link
Contributor

What this PR does / why we need it:

This PR:

  • makes sure this host benchmark config is propagated to the agent, this was not the case when it was disabled
  • turns the config on by default, matching the default value from the agent

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@paulcacheux paulcacheux requested a review from a team as a code owner July 8, 2024 11:58
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Jul 8, 2024
@paulcacheux paulcacheux force-pushed the paulcacheux/fix-host-bench-enabled branch from 5105b90 to 94ee646 Compare July 8, 2024 11:59
Co-authored-by: Celene <celene@datadoghq.com>
@paulcacheux paulcacheux force-pushed the paulcacheux/fix-host-bench-enabled branch from da7c0e8 to b660b08 Compare July 9, 2024 12:07
@paulcacheux paulcacheux requested a review from celenechang July 9, 2024 12:09
@celenechang celenechang merged commit e69bb42 into main Jul 9, 2024
17 checks passed
@celenechang celenechang deleted the paulcacheux/fix-host-bench-enabled branch July 9, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants