-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[cleanup] remove unused v1beta1 version of PDB (#1468)" #1580
Conversation
This reverts commit 614b10f.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 48.65% 48.56% -0.09%
==========================================
Files 226 226
Lines 20385 20435 +50
==========================================
+ Hits 9919 9925 +6
- Misses 9947 9989 +42
- Partials 519 521 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
* Revert "[cleanup] remove unused v1beta1 version of PDB (#1468)" This reverts commit 614b10f. * use go convention * support v1beta1 for pdbs * go convetion * Revert "support v1beta1 for pdbs" This reverts commit 13b2cab. * Reapply "support v1beta1 for pdbs" This reverts commit 59715f1. --------- Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com> Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
… (#1582) * Revert "[cleanup] remove unused v1beta1 version of PDB (#1468)" This reverts commit 614b10f. * use go convention * support v1beta1 for pdbs * go convetion * Revert "support v1beta1 for pdbs" This reverts commit 13b2cab. * Reapply "support v1beta1 for pdbs" This reverts commit 59715f1. --------- Co-authored-by: Sarah Wang <sarah.wang@datadoghq.com>
What does this PR do?
This reverts commit 614b10f (https://github.com/DataDog/datadog-operator/pull/1468/files) which removed support for v1beta1
This modifies create Pod Disruption Budget for DCA and CCR deployments #1454 to use v1beta1 when necessary to create the PDBs (otherwise, the simple revert leads to logs such as:
Motivation
make integration-test
fails here: https://github.com/DataDog/helm-charts/actions/runs/12395102380/job/34600023919?pr=1641 because of removal of v1beta1Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Same QA instructions for #1454, but also test with k8s 1.18
Checklist
bug
,enhancement
,refactoring
,documentation
,tooling
, and/ordependencies
qa/skip-qa
label