Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] PDB v1beta1 support fix #1582

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

tbavelier
Copy link
Member

What does this PR do?

Cherry-picks #1580

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* Revert "[cleanup] remove unused v1beta1 version of PDB (#1468)"

This reverts commit 614b10f.

* use go convention

* support v1beta1 for pdbs

* go convetion

* Revert "support v1beta1 for pdbs"

This reverts commit 13b2cab.

* Reapply "support v1beta1 for pdbs"

This reverts commit 59715f1.

---------

Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
Co-authored-by: Timothée Bavelier <97530782+tbavelier@users.noreply.github.com>
@tbavelier tbavelier added the bug Something isn't working label Dec 19, 2024
@tbavelier tbavelier added this to the v1.11.0 milestone Dec 19, 2024
@tbavelier tbavelier requested a review from a team as a code owner December 19, 2024 16:07
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 24.59016% with 46 lines in your changes missing coverage. Please review.

Project coverage is 48.57%. Comparing base (e3bd1a3) to head (2da2522).

Files with missing lines Patch % Lines
...oller/datadogagent/component/clusteragent/utils.go 12.50% 13 Missing and 1 partial ⚠️
...adogagent/component/clusterchecksrunner/default.go 12.50% 13 Missing and 1 partial ⚠️
pkg/kubernetes/platforminfo.go 33.33% 10 Missing ⚠️
pkg/equality/equality.go 0.00% 6 Missing ⚠️
pkg/kubernetes/objects.go 0.00% 1 Missing ⚠️
pkg/kubernetes/objectslist.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v1.11    #1582      +/-   ##
==========================================
- Coverage   48.66%   48.57%   -0.09%     
==========================================
  Files         226      226              
  Lines       20363    20413      +50     
==========================================
+ Hits         9909     9915       +6     
- Misses       9937     9979      +42     
- Partials      517      519       +2     
Flag Coverage Δ
unittests 48.57% <24.59%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l/controller/datadogagent/override/dependencies.go 56.98% <100.00%> (+0.94%) ⬆️
.../controller/datadogagent/testutils/client_utils.go 100.00% <ø> (ø)
internal/controller/datadogagent_controller.go 67.59% <100.00%> (+0.30%) ⬆️
pkg/kubernetes/objects.go 0.00% <0.00%> (ø)
pkg/kubernetes/objectslist.go 0.00% <0.00%> (ø)
pkg/equality/equality.go 7.05% <0.00%> (-0.29%) ⬇️
pkg/kubernetes/platforminfo.go 64.28% <33.33%> (-8.45%) ⬇️
...oller/datadogagent/component/clusteragent/utils.go 22.50% <12.50%> (-5.86%) ⬇️
...adogagent/component/clusterchecksrunner/default.go 9.58% <12.50%> (-1.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3bd1a3...2da2522. Read the comment docs.

@tbavelier tbavelier merged commit 79d9d52 into v1.11 Dec 19, 2024
18 checks passed
@tbavelier tbavelier deleted the tbavelier/cherry-pick-1580 branch December 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants