Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-1651 Add tvOS Support #793

Merged
merged 29 commits into from
Mar 29, 2022
Merged

RUMM-1651 Add tvOS Support #793

merged 29 commits into from
Mar 29, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Mar 28, 2022 •
edited
Loading

What and why?

Add tvOS Support

Fix #293

How?

Merge the following PRs to develop:

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

maxep and others added 29 commits March 28, 2022 20:21
@maxep
RUMM-2033 Add tvOS compatibility
16f7d57
@maxep
RUMM-2033 Rename iOS targets
ae56e12
@maxep
RUMM-2023 Update bitrise configuration
6ed0f5f
@maxep
RUMM-2033 Create Datadog tvOS targets
7481a09
@maxep
RUMM-2023 Update bitrise configuration
80d2f44
@maxep
RUMM-2023 Update Makefile for tvOS
bb6da1a
@maxep
RUMM-2023 Fix tvOS CR coverage
00bc035
@maxep
RUMM-2036 Add tvOS deployment target to podspec
cd99e23
@maxep
RUMM-2036 CocoaPods tvOS integration tests
fef933e
@maxep
RUMM-2037 Add tvOS platform to Package.swift
2058e36
@maxep
RUMM-2037 SPM tvOS integration tests
6748460
@maxep
RUMM-2037 Fix make create-src-from-xcodeproj
4b348c0
@maxep
RUMM-2045 Fix DatadogObjc tvOS build
24b7e41
@maxep
RUMM-2045 Carthage tvOS integration tests
a57afa4
@maxep
RUMM-2045 Do not embed DatadogCrashReporter.xcframework
acff4bb
@maxep
RUMM-2034 Rename Example iOS target
170de04
@maxep
RUMM-2034 Add Example tvOS
39ffcb4
@maxep
RUMM-2034 Do not embed CrashReporter.xcframework
4b7e00b
@maxep
RUMM-2035 Support tvOS click action with UIKit auto-instrumentation
842ffc9
@maxep
RUMM-2035 Support tvOS click action with SwiftUI
53b50d4
@maxep
RUMM-2035 Remove empty folder
2f90be3
@maxep
RUMM-2035 Update SwiftUI documentation
4958f4b
@maxep
RUMM-2035 Split press and touch predicates and apply changes to objc
557604f
@maxep
RUMM-2035 Remove objc typealias
20c4af9
@maxep
RUMM-2035 Remove SwiftUI click instrumentation on tvOS
849b94d
@maxep @ncreated
RUMM-2035 Rename test
5b4c857 
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
@maxep
RUMM-2054 Build and validate xcframework with tvos slices
25dfab7
@maxep
RUMM-1651 Add CI Test integration to tvOS
780e121
@maxep
RUMM-1651 Update CHANGELOG
8bb9aab
@maxep maxep marked this pull request as ready for review March 28, 2022 20:22
@maxep maxep requested a review from a team as a code owner March 28, 2022 20:22
ncreated
ncreated approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine 👌 (all changes already reviewed in separate PRs + the CHANGELOG entry looks good).

@maxep maxep merged commit 1c3e2b0 into develop Mar 29, 2022
@maxep maxep self-assigned this Mar 29, 2022
This was referenced Apr 1, 2022
Closed
Merged
@ncreated ncreated deleted the feature/tvos branch December 30, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees

@maxep maxep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support tvOS
2 participants
@maxep @ncreated