Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dogfooding branch build for tvOS and dogfood recent changes #799

Merged
merged 142 commits into from
Apr 4, 2022

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Apr 4, 2022

What and why?

🐶 Dogfooding recent changes (notably tvOS support, UA headers redaction and CI app integration):

In contrast to #798, this PR includes one more commit, which excludes running MetricKit logic for tvOS (otherwise the CI won't pass, like in #798). We use MK only on dogfooding branch.

How?

  • created ncreated/fix-dogfooding-branch-for-tvOS branch from dogfooding
  • merged develop into ncreated/fix-dogfooding-branch-for-tvOS (05201f2)
  • added 1db8993 to fix the tvOS problem
  • now raising PR into dogfooding

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

alai97 and others added 30 commits January 28, 2022 12:23
Implements absolute URLs for the doc site and copy nits.
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
so we can share some of this code with dogfooding tool.
Without removing ScriptMessageHandlers explicitly, they stay alive in memory
even after deallocation of the webview
so we can share some of their concepts.
to ensure that the version of Flutter in `dd-sdk-ios` CI env is equal or ahead
of the version in `dd-sdk-flutter`. This is to let Flutter's example and integration tests
project resolve its dependencies.
Adds a link to the source code for the `DDRUMMonitor` class + addresses copy nits.
Co-authored-by: May Lee <mayl@alumni.cmu.edu>
…WebEvents

RUMM-1931 stopTrackingDatadogEvents added to avoid memory leaks
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
RUMM-1956 Document all regions in setup instruction
maxep and others added 21 commits March 28, 2022 20:21
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
(only if the frame has no library base address read).
…ack-frames-with-addr-0x00

RUMM-2025 Filter out unrecognized trailing stack frame in `error.stack`
…-signature

RUMM-2091 Fix log event scrubbing signature
@ncreated ncreated requested review from a team as code owners April 4, 2022 07:42
@ncreated ncreated self-assigned this Apr 4, 2022
@ncreated ncreated removed the request for review from a team April 4, 2022 07:42
@ncreated ncreated mentioned this pull request Apr 4, 2022
3 tasks
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

@ncreated ncreated merged commit 9bf2302 into dogfooding Apr 4, 2022
@ncreated ncreated deleted the ncreated/fix-dogfooding-branch-for-tvOS branch April 4, 2022 13:17
@ncreated ncreated mentioned this pull request Apr 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants