RUMM-1931 stopTrackingDatadogEvents added to avoid memory leaks #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without removing ScriptMessageHandlers explicitly, they stay alive in memory even after deallocation of the webview
maxep
approved these changes
Feb 8, 2022
| /// Disables Datadog iOS SDK and Datadog Browser SDK integration. | ||
| /// | ||
| /// Removes Datadog's ScriptMessageHandler and UserScript from the caller. | ||
| /// _NOTE:_ This method **must** be called when the webview can be deinitialized. |
There was a problem hiding this comment.
This won't render properly, better to use
Suggested change
| /// _NOTE:_ This method **must** be called when the webview can be deinitialized. | |
| /// - Note: This method **must** be called when the webview can be deinitialized. |
Comment on lines
27
to
29
| func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) { | ||
| return | ||
| } |
There was a problem hiding this comment.
/nit
Suggested change
| func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) { | |
| return | |
| } | |
| func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) { } |
|
|
||
| controller.trackDatadogEvents(in: []) | ||
|
|
||
| let componentCount = 10 |
There was a problem hiding this comment.
why make it 10? I guess adding a single or a couple of other scripts will cover this change
ncreated
approved these changes
Feb 8, 2022
buranmert
force-pushed
the
buranmert/RUMM-1931-stopTrackingWebEvents
branch
from
c43e372 to
deb2ddd
Compare
This was referenced Apr 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Without removing
WKScriptMessageHandlersexplicitly, they stay alive in memory even after deallocation of the webviewHow?
By calling
stopTrackingDatadogEvents, our users can remove Datadog components from theirWKWebViewConfigurationinstances so thatDatadogMessageHandlercan be deallocated.Review checklist