RUMM-2025 Filter out unrecognized trailing stack frame in error.stack
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(only if the frame has no library base address read).
ncreated
deleted the
ncreated/RUMM-2025-filter-out-stack-frames-with-addr-0x00
branch
This was referenced Apr 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR aims at improving the symbolicated
error.stackby removing trailing???frame (if present).Going from this:
to this:
The root cause of
???is lack of library base address resolved for the frame. This makes its symbolication impossible. This line describes the very entry point to the code execution (even beforemain), so nothing actionable. To keep the symbolicated stack clean and avoid false positive symbolication errors, we truncate it.How?
Only the last frame is dropped and only if it couldn't be symbolicated.
Review checklist