Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2938 Move DatadogSessionReplay Sources and Tests #1149

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

maxep
Copy link
Member

@maxep maxep commented Feb 1, 2023

What and why?

Move sources and tests to comply with future project structure and facilitate migration in v2

This needs to be done early so we can keep the v2 branch up to date with develop.
@ncreated and @maciejburda make sure to rebase your current branches after this is merged to develop.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests
  • Run integration tests
  • Run smoke tests

@maxep maxep requested a review from a team as a code owner February 1, 2023 18:33
@maxep maxep self-assigned this Feb 1, 2023
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 1, 2023

Datadog Report

Branch report: maxep/remove-nested-sr-package
Commit report: 8f05f1a

dd-sdk-ios: 0 Failed, 0 New Flaky, 116 Passed, 0 Skipped, 5m 4.07s Wall Time

Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one, but isn't that the case already?
Screenshot 2023-02-02 at 16 24 26

Also - would be great to wait for that one before we merge:
#1144

I hope to merge it by the end of the week.

@maxep
Copy link
Member Author

maxep commented Feb 2, 2023

I trust you on this one, but isn't that the case already?

It's currently DatadogSessionReplay/Sources/DatadogSessionReplay/, I'm removing the last DatadogSessionReplay folder.

Totally, lets wait for #1144 👍

Base automatically changed from maxep/remove-nested-packages to develop February 2, 2023 17:17
@maxep maxep force-pushed the maxep/remove-nested-sr-package branch 2 times, most recently from 5088941 to 8f05f1a Compare February 6, 2023 10:30
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and good to merge after #1144 👍.

Alternatively, to avoid waiting or struggling with git conflicts, we could use two symbolic links (DDSR/Sources/DDSRDDSR/Sources, DDSR/Tests/DDSRTestsDDSR/Tests) for the period o migration and just move all files at once during a short code freeze at the end.

@maciejburda
Copy link
Member

Blocking PR merged 🟢

@maxep maxep force-pushed the maxep/remove-nested-sr-package branch from 8f05f1a to f5e2326 Compare February 13, 2023 08:42
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 13, 2023

Datadog Report

Branch report: maxep/remove-nested-sr-package
Commit report: f5e2326

dd-sdk-ios: 1 Failed (0 Known Flaky), 0 New Flaky, 1544 Passed, 0 Skipped, 39m 14.76s Wall Time

❌ Failed Tests (1)

  • testRUMTabBarScenario - RUMTabBarControllerScenarioTests - Details

    Expand for error
     Segmentation fault. Check error.crash_log for the full crash log.
    

@maxep maxep merged commit 5491d29 into develop Feb 13, 2023
@maxep maxep deleted the maxep/remove-nested-sr-package branch February 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants