-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-2938 Move DatadogSessionReplay Sources and Tests #1149
Conversation
Datadog ReportBranch report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you on this one, but isn't that the case already?
Also - would be great to wait for that one before we merge:
#1144
I hope to merge it by the end of the week.
It's currently Totally, lets wait for #1144 👍 |
5088941
to
8f05f1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and good to merge after #1144 👍.
Alternatively, to avoid waiting or struggling with git conflicts, we could use two symbolic links (DDSR/Sources/DDSR
→ DDSR/Sources
, DDSR/Tests/DDSRTests
→ DDSR/Tests
) for the period o migration and just move all files at once during a short code freeze at the end.
Blocking PR merged 🟢 |
8f05f1a
to
f5e2326
Compare
Datadog ReportBranch report: ❌ ❌ Failed Tests (1)
|
What and why?
Move sources and tests to comply with future project structure and facilitate migration in v2
This needs to be done early so we can keep the v2 branch up to date with
develop
.@ncreated and @maciejburda make sure to rebase your current branches after this is merged to
develop
.Review checklist
Custom CI job configuration (optional)